From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F9EB457A1; Mon, 12 Aug 2024 14:00:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2D4F402C3; Mon, 12 Aug 2024 14:00:14 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 28F524029C for ; Mon, 12 Aug 2024 14:00:13 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id CE4EF9E for ; Mon, 12 Aug 2024 14:00:12 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C168D9D; Mon, 12 Aug 2024 14:00:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.3 Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 048E91FF73; Mon, 12 Aug 2024 14:00:11 +0200 (CEST) Message-ID: <99c5ae9f-454e-4bb9-bd42-110aea7e05b2@lysator.liu.se> Date: Mon, 12 Aug 2024 14:00:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] eal: add atomic bit operations To: Jack Bond-Preston , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org Cc: Heng Wang , Stephen Hemminger , Joyce Kong , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20240809090439.589295-2-mattias.ronnblom@ericsson.com> <20240809095829.589396-1-mattias.ronnblom@ericsson.com> <20240809095829.589396-4-mattias.ronnblom@ericsson.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-08-12 13:19, Jack Bond-Preston wrote: > On 09/08/2024 10:58, Mattias Rönnblom wrote: >> >> + >> +#define __RTE_GEN_BIT_ATOMIC_OPS(size)            \ >> +    __RTE_GEN_BIT_ATOMIC_TEST(size)            \ >> +    __RTE_GEN_BIT_ATOMIC_SET(size)            \ >> +    __RTE_GEN_BIT_ATOMIC_CLEAR(size)        \ >> +    __RTE_GEN_BIT_ATOMIC_ASSIGN(size)        \ >> +    __RTE_GEN_BIT_ATOMIC_TEST_AND_SET(size)        \ >> +    __RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(size)    \ >> +    __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size)    \ >> +    __RTE_GEN_BIT_ATOMIC_FLIP(size) >> + >> +__RTE_GEN_BIT_ATOMIC_OPS(32) >> +__RTE_GEN_BIT_ATOMIC_OPS(64) > > For the non-atomic operations, the arguments family and qualifier were > added in the initial commit, and unused until the > volatile-support-adding commit. Perhaps the atomic equivalents should be > the same? (ie. add the family and qualifier arguments in this patch and > don't use them until patch 5/5. > Sounds like a good idea. >> + >>   /*------------------------ 32-bit relaxed operations >> ------------------------*/ >>   /** >>