* [dpdk-dev] [PATCH] net/virtio: do not use PMD log type
@ 2021-09-16 13:25 David Marchand
2021-09-28 10:02 ` Maxime Coquelin
2021-09-28 15:37 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: David Marchand @ 2021-09-16 13:25 UTC (permalink / raw)
To: dev; +Cc: thomas, stable, Maxime Coquelin, Chenbo Xia, Marvin Liu
Fixes: 1982462eadea ("net/virtio: add Rx free threshold setting")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/virtio/virtio_rxtx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 501ca1582d..b9d7c8d18f 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -690,16 +690,16 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,
RTE_MIN(vq->vq_nentries / 4, DEFAULT_RX_FREE_THRESH);
if (rx_free_thresh & 0x3) {
- RTE_LOG(ERR, PMD, "rx_free_thresh must be multiples of four."
- " (rx_free_thresh=%u port=%u queue=%u)\n",
+ PMD_INIT_LOG(ERR, "rx_free_thresh must be multiples of four."
+ " (rx_free_thresh=%u port=%u queue=%u)",
rx_free_thresh, dev->data->port_id, queue_idx);
return -EINVAL;
}
if (rx_free_thresh >= vq->vq_nentries) {
- RTE_LOG(ERR, PMD, "rx_free_thresh must be less than the "
+ PMD_INIT_LOG(ERR, "rx_free_thresh must be less than the "
"number of RX entries (%u)."
- " (rx_free_thresh=%u port=%u queue=%u)\n",
+ " (rx_free_thresh=%u port=%u queue=%u)",
vq->vq_nentries,
rx_free_thresh, dev->data->port_id, queue_idx);
return -EINVAL;
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: do not use PMD log type
2021-09-16 13:25 [dpdk-dev] [PATCH] net/virtio: do not use PMD log type David Marchand
@ 2021-09-28 10:02 ` Maxime Coquelin
2021-09-28 15:37 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2021-09-28 10:02 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas, stable, Chenbo Xia, Marvin Liu
On 9/16/21 15:25, David Marchand wrote:
> Fixes: 1982462eadea ("net/virtio: add Rx free threshold setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: do not use PMD log type
2021-09-16 13:25 [dpdk-dev] [PATCH] net/virtio: do not use PMD log type David Marchand
2021-09-28 10:02 ` Maxime Coquelin
@ 2021-09-28 15:37 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2021-09-28 15:37 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas, stable, Chenbo Xia, Marvin Liu
On 9/16/21 15:25, David Marchand wrote:
> Fixes: 1982462eadea ("net/virtio: add Rx free threshold setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 13:25 [dpdk-dev] [PATCH] net/virtio: do not use PMD log type David Marchand
2021-09-28 10:02 ` Maxime Coquelin
2021-09-28 15:37 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).