From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 4E4F8108A
 for <dev@dpdk.org>; Tue,  7 Mar 2017 11:51:11 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 07 Mar 2017 02:51:11 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,258,1484035200"; 
 d="scan'208,217";a="233188268"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.191.241])
 ([10.254.191.241])
 by fmsmga004.fm.intel.com with ESMTP; 07 Mar 2017 02:51:09 -0800
To: Qi Zhang <qi.z.zhang@intel.com>, jingjing.wu@intel.com,
 helin.zhang@intel.com
References: <20170303015924.68986-1-qi.z.zhang@intel.com>
 <20170303015924.68986-2-qi.z.zhang@intel.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <99df9cb9-cbad-d41a-7b99-2888e4f926cb@intel.com>
Date: Tue, 7 Mar 2017 10:51:08 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20170303015924.68986-2-qi.z.zhang@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: enable VF untag drop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Mar 2017 10:51:12 -0000

On 3/3/2017 1:59 AM, Qi Zhang wrote:
> Add a new private API to support the untag drop enable/disable
> for specific VF.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c  | 49 +++++++++++++++++++++++++++++++++++++++++
>  drivers/net/i40e/rte_pmd_i40e.h | 18 +++++++++++++++

Shared library is giving build error because of API is missing in
*version.map file

>  2 files changed, 67 insertions(+)
> 

<...>

> diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
> index a0ad88c..895e2cc 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -332,4 +332,22 @@ int rte_pmd_i40e_get_vf_stats(uint8_t port,
>  int rte_pmd_i40e_reset_vf_stats(uint8_t port,
>  				uint16_t vf_id);
>  
> +/**
> + * Enable/Disable VF untag drop
> + *
> + * @param port
> + *    The port identifier of the Ethernet device.
> + * @param vf_id
> + *    VF on witch to enable/disable
> + * @param on
> + *    Enable or Disable
> + * @retura

@return

> + *  - (0) if successful.
> + *  -(-ENODEVE) if *port* invalid
> + *  -(-EINVAL) if bad parameter.
> + */
> +int rte_pmd_i40e_set_vf_vlan_untag_drop(uint8_t port,
> +					uint16_t vf_id,
> +					uint8_t on);

As discussed previously, I believe it is good to keep following syntax
in API:
<name_space>_<object>_<action>, for this API it becomes:

rte_pmd_i40e_vf_vlan_untag_drop_set(), and perhaps "set" can be removed?

> +
>  #endif /* _PMD_I40E_H_ */
>