From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id CB48B1B1B6 for ; Mon, 16 Apr 2018 09:26:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 115BD402290A; Mon, 16 Apr 2018 07:26:43 +0000 (UTC) Received: from [10.36.112.56] (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B58822166BAD; Mon, 16 Apr 2018 07:26:40 +0000 (UTC) To: Thomas Monjalon , Zhihong Wang Cc: dev@dpdk.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, yliu@fridaylinux.org, cunming.liang@intel.com, xiao.w.wang@intel.com, dan.daly@intel.com, ferruh.yigit@intel.com, bruce.richardson@intel.com References: <1517614137-62926-1-git-send-email-zhihong.wang@intel.com> <20180402114656.17090-3-zhihong.wang@intel.com> <3690370.7WaqRWydSG@xps> From: Maxime Coquelin Message-ID: <99eee6e5-1eae-9d5b-ca07-9cf9dd951486@redhat.com> Date: Mon, 16 Apr 2018 09:26:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3690370.7WaqRWydSG@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 07:26:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 07:26:43 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 07:26:44 -0000 On 04/15/2018 07:39 PM, Thomas Monjalon wrote: > 03/04/2018 10:02, Maxime Coquelin: >> On 04/02/2018 01:46 PM, Zhihong Wang wrote: >>> lib/librte_vhost/Makefile | 4 +- >>> lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++++++++++ >>> lib/librte_vhost/rte_vhost_version.map | 7 ++ >>> lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++++++++++++ >> >> With the fix you suggested: >> Reviewed-by: Maxime Coquelin > > This patch is not OK. It is updating the Makefile but not meson.build. > I am fixing/amending it in master: > > --- a/lib/librte_vhost/meson.build > +++ b/lib/librte_vhost/meson.build > @@ -9,7 +9,8 @@ if has_libnuma == 1 > endif > version = 4 > allow_experimental_apis = true > -sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c', > +sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c', > + 'vhost.c', 'vhost_user.c', > 'virtio_net.c', 'vhost_crypto.c') > -headers = files('rte_vhost.h', 'rte_vhost_crypto.h') > +headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h') > > > Right, thanks Thomas. Sorry for not catching this, I'm in the process of improving my build scripts, but as you can see it is not yet ready... Cheers, Maxime