DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>,
	"Wang, Haiyue" <haiyue.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH v1] net/af_xdp: make umem configure code more readable
Date: Thu, 10 Feb 2022 10:31:27 +0000	[thread overview]
Message-ID: <99fecfc6-a52b-46c0-f79f-96260008f1bb@intel.com> (raw)
In-Reply-To: <CO1PR11MB4785106C4C2E9F0CEF660B878E2F9@CO1PR11MB4785.namprd11.prod.outlook.com>

On 2/10/2022 8:53 AM, Loftus, Ciara wrote:
>> Subject: [PATCH v1] net/af_xdp: make umem configure code more readable
>>
>> The below compile time defined style make the code not so readable, the
>> first function end block is after "#endif" segment.
>>
>> 	#if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)
>>
>> 	xdp_umem_configure()
>> 	{
>>
>> 	#else
>> 	xdp_umem_configure()
>> 	{
>>
>> 	#endif
>> 		'shared code block'
>> 	}
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> 
> Thanks for the patch!
> 
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> 

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2022-02-10 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 12:43 Haiyue Wang
2022-02-10  8:53 ` Loftus, Ciara
2022-02-10 10:31   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99fecfc6-a52b-46c0-f79f-96260008f1bb@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).