From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <rami.rosen@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 1547B1C9B9
for <dev@dpdk.org>; Fri, 6 Apr 2018 21:42:09 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
06 Apr 2018 12:42:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,416,1517904000"; d="scan'208";a="41293276"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga003.jf.intel.com with ESMTP; 06 Apr 2018 12:42:08 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Fri, 6 Apr 2018 12:42:07 -0700
Received: from hasmsx106.ger.corp.intel.com (10.184.198.20) by
fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Fri, 6 Apr 2018 12:42:07 -0700
Received: from HASMSX110.ger.corp.intel.com ([169.254.6.223]) by
HASMSX106.ger.corp.intel.com ([169.254.10.253]) with mapi id 14.03.0319.002;
Fri, 6 Apr 2018 22:42:04 +0300
From: "Rosen, Rami" <rami.rosen@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "thomas@monjalon.net"
<thomas@monjalon.net>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup
Thread-Index: AQHTyi6w6xKoqGP4cUG3XQsCRFWJIKP0KWxA
Date: Fri, 6 Apr 2018 19:42:03 +0000
Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
<20180402025935.33312-1-qi.z.zhang@intel.com>
<20180402025935.33312-2-qi.z.zhang@intel.com>
In-Reply-To: <20180402025935.33312-2-qi.z.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzliN2YxZjYtZjdlMi00N2RjLTk4MjUtMTcxM2YxMGQ5YTdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMXC9hRHloMTZrME5ZQXU4Mkp6TURvN0J0TDQzdFVDTUJcL0Z5ZzMzNUVCWGhva3NFOTJGWTF0RlMwVjRKSDhHSzkifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.255.201.130]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 19:42:10 -0000
Hi Qi,
Thanks for these patches.
See my comment below.
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
Sent: Monday, April 02, 2018 06:00
To: thomas@monjalon.net; Ananyev, Konstantin <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingj=
ing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zh=
ang@intel.com>
Subject: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup
The patch let etherdev driver expose the capability flag through rte_eth_de=
v_info_get when it support runtime queue configuraiton, then base on the fl=
ag rte_eth_[rx|tx]_queue_setup could decide continue to setup the queue or =
just return fail when device already started.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
doc/guides/nics/features.rst | 8 ++++++++ lib/librte_ether/rte_ethdev.c=
| 30 ++++++++++++++++++------------ lib/librte_ether/rte_ethdev.h | 7 ++=
+++++
3 files changed, 33 insertions(+), 12 deletions(-)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst in=
dex 1b4fb979f..6983faa4e 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -892,7 +892,15 @@ Documentation describes performance values.
=20
See ``dpdk.org/doc/perf/*``.
=20
+.. _nic_features_queue_runtime_setup_capabilities:
=20
+Queue runtime setup capabilities
+---------------------------------
+
+Supports queue setup / release after device started.
+
+* **[provides] rte_eth_dev_info**: ``runtime_queue_config_capa:DEV_RUNTIME=
_RX_QUEUE_SETUP,DEV_RUNTIME_TX_QUEUE_SETUP``.
+* **[related] API**: ``rte_eth_dev_info_get()``.
=20
.. _nic_features_other:
=20
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c =
index 0590f0c10..343b1a6c0 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx=
_queue_id,
return -EINVAL;
}
=20
- if (dev->data->dev_started) {
- RTE_PMD_DEBUG_TRACE(
- "port %d must be stopped to allow configuration\n", port_id);
- return -EBUSY;
- }
-
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, -ENOTSUP);
=20
@@ -1474,6 +1468,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx=
_queue_id,
return -EINVAL;
}
=20
+ if (dev->data->dev_started &&
+ !(dev_info.runtime_queue_setup_capa &
+ DEV_RUNTIME_RX_QUEUE_SETUP))
+ return -EBUSY;
+
+ if (dev->data->rx_queue_state[rx_queue_id] !=3D
+ RTE_ETH_QUEUE_STATE_STOPPED)
+ return -EBUSY;
+
rxq =3D dev->data->rx_queues;
if (rxq[rx_queue_id]) {
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,
@@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx=
_queue_id,
return -EINVAL;
}
=20
- if (dev->data->dev_started) {
- RTE_PMD_DEBUG_TRACE(
- "port %d must be stopped to allow configuration\n", port_id);
- return -EBUSY;
- }
-
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, -ENOTSUP);
=20
@@ -1596,6 +1593,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx=
_queue_id,
return -EINVAL;
}
=20
+ if (dev->data->dev_started &&
+ !(dev_info.runtime_queue_setup_capa &
+ DEV_RUNTIME_TX_QUEUE_SETUP))
+ return -EBUSY;
+
[Rami Rosen] Shouldn't it be here: dev->data->tx_queue_state[...] instead o=
f:
dev->data->rx_queue_state[...] ? we are dealing wit=
h the TX queue.
+ if (dev->data->rx_queue_state[tx_queue_id] !=3D
+ RTE_ETH_QUEUE_STATE_STOPPED)
+ return -EBUSY;
+
txq =3D dev->data->tx_queues;
if (txq[tx_queue_id]) {
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h =
index 036153306..4e2088458 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -981,6 +981,11 @@ struct rte_eth_conf {
*/
#define DEV_TX_OFFLOAD_SECURITY 0x00020000
=20
+#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred setup rx=20
+queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002 /**< Deferred=20
+setup tx queue */
+
/*
* If new Tx offload capabilities are defined, they also must be
* mentioned in rte_tx_offload_names in rte_ethdev.c file.
@@ -1029,6 +1034,8 @@ struct rte_eth_dev_info {
/** Configured number of rx/tx queues */
uint16_t nb_rx_queues; /**< Number of RX queues. */
uint16_t nb_tx_queues; /**< Number of TX queues. */
+ uint64_t runtime_queue_setup_capa;
+ /**< queues can be setup after dev_start (DEV_DEFERRED_). */
};
=20
/**
--
2.13.6