From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 26B94952
 for <dev@dpdk.org>; Mon, 11 Jul 2016 09:29:22 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 11 Jul 2016 00:29:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="992668271"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 11 Jul 2016 00:29:15 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 11 Jul 2016 00:29:07 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.147]) with mapi id 14.03.0248.002;
 Mon, 11 Jul 2016 15:29:06 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] i40e: move PCI device ids to driver
Thread-Index: AQHR2yjq2JYCssgy40WAqbIv8UxtvqASO/YAgAAKAQCAAAHqgIAAimMA
Date: Mon, 11 Jul 2016 07:29:05 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F80E16A0F6@SHSMSX103.ccr.corp.intel.com>
References: <1468209673-21685-1-git-send-email-jingjing.wu@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E717D953B3@SHSMSX103.ccr.corp.intel.com>
 <2755332.bbWM3o0Z6X@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E717D95497@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E717D95497@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] i40e: move PCI device ids to driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2016 07:29:22 -0000

Hi, helin

What I did is exactly same as what David's patch set did in i40e. I agree w=
ith his change.
About the new header file, there is already i40e_devids.h in base code whic=
h defines the device IDs and vendor ID. This patch just combines them to be=
 a pci device id in struct pci_id_i40e_map in source file. So I don't think=
 a new header file is required. And about kernel driver, I checked it and i=
t did in the similar way.

Thanks
Jingjing

> -----Original Message-----
> From: Zhang, Helin
> Sent: Monday, July 11, 2016 3:02 PM
> To: Thomas Monjalon
> Cc: Wu, Jingjing; dev@dpdk.org
> Subject: RE: [PATCH] i40e: move PCI device ids to driver
>=20
> Hi Thomas
>=20
> It should be the one from David as I read that before. I am not sure if a=
ll PMD
> has its own header files for device IDs, but I did see there was.
> Even in recent kernel drivers (e.g. i40e), there is a new header file for=
 device
> ID list. I think it could be clearer, though no correct or wrong.
>=20
> Regards,
> Helin
>=20
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Monday, July 11, 2016 2:55 PM
> > To: Zhang, Helin
> > Cc: Wu, Jingjing; dev@dpdk.org
> > Subject: Re: [PATCH] i40e: move PCI device ids to driver
> >
> > Hi Helin,
> >
> > 2016-07-11 06:19, Zhang, Helin:
> > > Hi Jingjing
> > >
> > > I'd suggest to add a new header file in each PMD to define what we
> defined
> > in rte_pci_dev_ids.h.
> >
> > Why?
> >
> > > There was a patch set submitted several months ago, like that.
> >
> > Which one?