From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A18A62BA1 for ; Mon, 11 Jul 2016 09:51:03 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 11 Jul 2016 00:51:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="843972718" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 11 Jul 2016 00:50:49 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 11 Jul 2016 00:50:49 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 11 Jul 2016 00:50:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by shsmsx102.ccr.corp.intel.com ([169.254.2.147]) with mapi id 14.03.0248.002; Mon, 11 Jul 2016 15:50:46 +0800 From: "Wu, Jingjing" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup Thread-Index: AQHR2zyQVgaLRp7ygUqCsFl/fpaXYaAS2ziw Date: Mon, 11 Jul 2016 07:50:45 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F80E16A11F@SHSMSX103.ccr.corp.intel.com> References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 07:51:04 -0000 Hi, Wenzhuo I don't think you need to create a new API: rte_eth_dev_bypass_supported. If bypass in not supported, the Ops for bypass feature will not be implemen= ted in driver, or driver need to return NOT supported. So I think what you need do is just remove the NIC specific things from tes= tpmd, including "bypass_is_supported". Thanks Jingjing > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, July 11, 2016 2:21 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup >=20 > In testpmd code, device id is used directly to check if bypass is support= ed. > But APP should not know the details of HW, the NIC specific info should n= ot > be exposed here. > This patch adds a new rte API to check if bypass is supported. >=20 > Signed-off-by: Wenzhuo Lu