From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D8A3F6CA4 for ; Mon, 10 Oct 2016 16:36:44 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 10 Oct 2016 07:36:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="1042718317" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 10 Oct 2016 07:36:42 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 07:36:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 07:36:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.234]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 22:36:38 +0800 From: "Wu, Jingjing" To: Zoltan Kiss , "dev@dpdk.org" CC: Matias Elo , "Gonzalez Monroy, Sergio" , "Yigit, Ferruh" , "damarion@cisco.com" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols Thread-Index: AQHR4qm5NNSiPGYSC0i3AYkkYu36/aCiPwOg Date: Mon, 10 Oct 2016 14:36:38 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F80E277FE5@SHSMSX103.ccr.corp.intel.com> References: <1468938920-19679-1-git-send-email-zoltan.kiss@schaman.hu> <1469034676-2424-1-git-send-email-zoltan.kiss@schaman.hu> In-Reply-To: <1469034676-2424-1-git-send-email-zoltan.kiss@schaman.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTgzYjc3ODgtYmRiYi00MDY3LThiODUtODM2MzVmNzkwZDA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJiV0lOd3RMNk5hNWlxUkpDOWdZc3Vjb3FEMW1LUDJiSURSV0U5WFM5OWc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 14:36:45 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zoltan Kiss > Sent: Thursday, July 21, 2016 1:11 AM > To: dev@dpdk.org > Cc: Matias Elo ; Gonzalez Monroy, Sergio > ; Yigit, Ferruh ; > damarion@cisco.com; thomas.monjalon@6wind.com > Subject: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols >=20 > Using weak symbols have a few issues with static linking: >=20 > - normally the linker searches the .o files already linked, if your weak > one is there, it won't check if there is a strong version > - unless the symbol is directly referred, but it's not the right thing to > rely on > - or --whole-archive specified in the command line, which pulls in a lot > of unwanted stuff > - whole-archive also makes libtool dropping the library from the command > line, which is what should happen with dynamic linking, but not with > static (observed on Ubuntu 14.04). This is an important bug if you > build a static library depending on DPDK >=20 > This patch merges the two version and make the behaviour rely on the > config. >=20 > If we can agree in the concept, I can send a series to fix this for the > other weak functions. >=20 > Signed-off-by: Zoltan Kiss > --- Looks good to remove weak symbols. Just one concern is vector PMD is one specific part to different Micro-Arch= itecture. It's better to keep independent from normal tx/rx files. Think about ixgbe_= rxtx_vec_neon.c and ixgbe_rxtx_vec_sse.c Thanks Jingjing