From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 6DCD55921
 for <dev@dpdk.org>; Tue, 25 Oct 2016 12:45:20 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga102.fm.intel.com with ESMTP; 25 Oct 2016 03:45:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="23738250"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga004.jf.intel.com with ESMTP; 25 Oct 2016 03:45:19 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 25 Oct 2016 03:45:18 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 25 Oct 2016 03:45:18 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002;
 Tue, 25 Oct 2016 18:45:15 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Helin" <helin.zhang@intel.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Thread-Topic: [PATCH v2 2/2] net/i40e: fix VF bonded device link down
Thread-Index: AQHSLneDoKcIsDW1NEqWXy1FYOBIiaC4/DXQ
Date: Tue, 25 Oct 2016 10:45:14 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F80E2946CE@SHSMSX103.ccr.corp.intel.com>
References: <1477369146-63317-1-git-send-email-qiming.yang@intel.com>
 <1477369146-63317-2-git-send-email-qiming.yang@intel.com>
In-Reply-To: <1477369146-63317-2-git-send-email-qiming.yang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTliMWZmMmQtZWJiNi00MmY4LTgwNzgtOThhNTg1MWRlZjdjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InAyeTluMVpnd0Z2YmNFRzN2WVNCNTlvVEl0WjJ1OEw2VHVpQ2dpK1JmcDA9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix VF bonded device link
	down
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2016 10:45:20 -0000



> -----Original Message-----
> From: Yang, Qiming
> Sent: Tuesday, October 25, 2016 12:19 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel=
.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: [PATCH v2 2/2] net/i40e: fix VF bonded device link down
>=20
> If VF device is used as slave of a bond device, it will be polled
> periodically through alarm. Interrupt is involved here. And then
> VF will send I40E_VIRTCHNL_OP_GET_LINK_STAT message to
> PF to query the status. The response is handled by interrupt
> callback. Interrupt is involved here again. That's why bond
> device cannot bring up.
>=20
> This patch removes I40E_VIRTCHNL_OP_GET_LINK_STAT
> message. Link status in VF driver will be updated when PF driver
> notify it, and VF stores this link status locally. VF driver just
> returns the local status when being required.
>=20
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>=20
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Thanks.
BTW, next time, don't forget to note your changes comparing the previous ve=
rsion.
It will make reviewers' life easy. :)


/Jingjing