From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 75E62BB38
 for <dev@dpdk.org>; Wed, 26 Oct 2016 16:30:24 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 26 Oct 2016 07:30:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; d="scan'208";a="1050494882"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by orsmga001.jf.intel.com with ESMTP; 26 Oct 2016 07:30:23 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 26 Oct 2016 07:30:22 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 26 Oct 2016 07:30:22 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002;
 Wed, 26 Oct 2016 22:30:20 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Shah, Rahul R" <rahul.r.shah@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "Dumitrescu, Cristian"
 <cristian.dumitrescu@intel.com>
Thread-Topic: [PATCH v6 2/2] app/test_pmd: fix DCB configuration
Thread-Index: AQHSLuAFwJ+wZftBeUq8/HU3RbY0HaC6y60w
Date: Wed, 26 Oct 2016 14:30:19 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F80E2953C5@SHSMSX103.ccr.corp.intel.com>
References: <1476872471-23362-1-git-send-email-bernard.iremonger@intel.com>
 <1477414269-27156-3-git-send-email-bernard.iremonger@intel.com>
In-Reply-To: <1477414269-27156-3-git-send-email-bernard.iremonger@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjU4OTBkZDMtZGRlMi00ZGZhLTgwNjEtYWVhNDdiY2U5MWU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IloxTXlyVmNzSUt3UWpwMEJwciswUUppa09RVzFST0diM3FPNklMZmt6ZW89In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 2/2] app/test_pmd: fix DCB configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2016 14:30:24 -0000


>  	if (dcb_mode =3D=3D DCB_VT_ENABLED) {
> -		nb_rxq =3D rte_port->dev_info.max_rx_queues;
> -		nb_txq =3D rte_port->dev_info.max_tx_queues;
> +		nb_rxq =3D 1;
> +		nb_txq =3D 1;
Before, the 'vt' argument in dcb command is used to distinguish whether the=
 VMDQ is involved, but does mean if SRIOV is enabled.
I guess you want to use mode=3D ETH_MQ_RX_VMDQ_DCB to cover both VMDQ+DCB a=
nd SRIOV+DCB cases.
But if set nb_rxq=3D1, VMDQ + DCB case will not work in testpmd. And even d=
oesn't care about the VMDQ +DCB case,
setting num of queue to 1 makes no sense to DCB (queue based on TC) cases.

Thanks
Jingjing