From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 21E7EF63E for ; Wed, 4 Jan 2017 08:51:49 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 03 Jan 2017 23:51:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="1107720615" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Jan 2017 23:51:49 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 23:51:49 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 15:51:45 +0800 From: "Wu, Jingjing" To: "Yang, Qiming" , "dev@dpdk.org" , "thomas.monjalon@6wind.com" CC: "Horton, Remy" , "Yigit, Ferruh" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware version Thread-Index: AQHSYELlrRQ+Hm861kOhdE3q1ZGhl6En/YSA Date: Wed, 4 Jan 2017 07:51:44 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CC2B0B@SHSMSX103.ccr.corp.intel.com> References: <1481008582-69416-6-git-send-email-qiming.yang@intel.com> <1482843968-6483-1-git-send-email-qiming.yang@intel.com> In-Reply-To: <1482843968-6483-1-git-send-email-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 07:51:50 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Tuesday, December 27, 2016 9:06 PM > To: dev@dpdk.org; thomas.monjalon@6wind.com > Cc: Horton, Remy ; Yigit, Ferruh > ; Yang, Qiming > Subject: [dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware ver= sion >=20 > This patch enhances the ethtool example to support to show bus informatio= n > and firmware version, in the same way that the Linux kernel ethtool does. >=20 > Signed-off-by: Qiming Yang > --- > v3 changes: > * split this patch from the patch set of rte_eth_dev_fw_info_get > use the new version function. > --- > --- > examples/ethtool/ethtool-app/ethapp.c | 2 ++ > examples/ethtool/lib/rte_ethtool.c | 11 +++++++++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/examples/ethtool/ethtool-app/ethapp.c > b/examples/ethtool/ethtool-app/ethapp.c > index 6aeaa06..192d941 100644 > --- a/examples/ethtool/ethtool-app/ethapp.c > +++ b/examples/ethtool/ethtool-app/ethapp.c > @@ -185,6 +185,8 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params, > printf("Port %i driver: %s (ver: %s)\n", > id_port, info.driver, info.version > ); > + printf("bus-info: %s\n", info.bus_info); This patch has dependence on your get_fw_version patch set. I think you may misunderstand Ferruh's comments, I think what he said was ask you to remove bus-info print (above line) from= that patch set, but keep firmware version print. Thanks Jingjing