From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1CC96F610 for ; Fri, 6 Jan 2017 01:33:07 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 05 Jan 2017 16:32:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="1090492030" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 05 Jan 2017 16:32:57 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 16:32:57 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 16:32:57 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Fri, 6 Jan 2017 08:32:55 +0800 From: "Wu, Jingjing" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v7 10/27] net/i40e: set VF MAC from PF support Thread-Index: AQHSZY7INqFAcaY7Ek2f6vnIV/2BT6EptPEw Date: Fri, 6 Jan 2017 00:32:54 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CC3CAA@SHSMSX103.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-11-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1483426488-117332-11-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 10/27] net/i40e: set VF MAC from PF support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 00:33:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:55 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v7 10/27] net/i40e: set VF MAC from PF support >=20 > From: Ferruh Yigit >=20 > Support setting VF MAC address from PF. > User can call the API on PF to set a specific VF's MAC address. >=20 > This will remove all existing MAC filters. >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/net/i40e/i40e_ethdev.c | 42 > +++++++++++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 19 ++++++++++++++ > drivers/net/i40e/rte_pmd_i40e_version.map | 1 + > 3 files changed, 62 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 9d050c8..758b574 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -10198,3 +10198,45 @@ static void i40e_set_default_mac_addr(struct > rte_eth_dev *dev, >=20 > return ret; > } > + > +int > +rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id, > + struct ether_addr *mac_addr) > +{ > + struct rte_eth_dev_info dev_info; > + struct i40e_mac_filter *f; > + struct rte_eth_dev *dev; > + struct i40e_pf_vf *vf; > + struct i40e_vsi *vsi; > + struct i40e_pf *pf; > + void *temp; > + > + if (i40e_validate_mac_addr((u8 *)mac_addr) !=3D I40E_SUCCESS) > + return -EINVAL; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev =3D &rte_eth_devices[port]; > + rte_eth_dev_info_get(port, &dev_info); > + > + if (vf_id >=3D dev_info.max_vfs) > + return -EINVAL; > + > + pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + > + if (vf_id > pf->vf_num - 1 || !pf->vfs) > + return -EINVAL; > + > + vf =3D &pf->vfs[vf_id]; > + vsi =3D vf->vsi; > + if (!vsi) > + return -EINVAL; > + > + ether_addr_copy(mac_addr, &vf->mac_addr); Only store the mac address in vf struct? Are you supposing the API is called before VF is initialized? If so, it's b= etter to comment it. Thanks Jingjing