From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 604FA2C01; Fri, 6 Jan 2017 02:29:15 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 05 Jan 2017 17:29:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="1079734458" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 05 Jan 2017 17:29:14 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 17:29:13 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 17:29:13 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Fri, 6 Jan 2017 09:29:11 +0800 From: "Wu, Jingjing" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Iremonger, Bernard" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close Thread-Index: AQHSZY9SpmzpFDG60EazecjOQF49O6EqrT5g Date: Fri, 6 Jan 2017 01:29:11 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CC3E79@SHSMSX103.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-27-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1483426488-117332-27-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 01:29:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Tuesday, January 3, 2017 2:55 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in = close >=20 > From: Bernard Iremonger >=20 > The vsi's have already been released, so the second call to i40e_vsi_rele= ase > results in a segmentation fault. > The second call to i40e_vsi_release has been removed. Where is the first call to release vmdq vsi? Thanks Jingjing >=20 > Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing") >=20 > CC: stable@dpdk.org >=20 > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index be45cfa..0b7c366 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1882,7 +1882,6 @@ static inline void i40e_GLQF_reg_init(struct i40e_h= w > *hw) > i40e_vsi_release(pf->main_vsi); >=20 > for (i =3D 0; i < pf->nb_cfg_vmdq_vsi; i++) { > - i40e_vsi_release(pf->vmdq[i].vsi); > pf->vmdq[i].vsi =3D NULL; > } >=20 > @@ -4137,6 +4136,9 @@ enum i40e_status_code > if (!vsi) > return I40E_SUCCESS; >=20 > + if (!vsi->adapter) > + return I40E_ERR_BAD_PTR; > + > user_param =3D vsi->user_param; >=20 > pf =3D I40E_VSI_TO_PF(vsi); > -- > 1.9.3