From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 926BCDE0
 for <dev@dpdk.org>; Mon,  6 Feb 2017 04:02:15 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga105.fm.intel.com with ESMTP; 05 Feb 2017 19:02:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,340,1477983600"; d="scan'208";a="221698834"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga004.fm.intel.com with ESMTP; 05 Feb 2017 19:02:14 -0800
Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 5 Feb 2017 19:02:14 -0800
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 5 Feb 2017 19:02:14 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002;
 Mon, 6 Feb 2017 11:02:12 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Helin" <helin.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported
 Tx flags
Thread-Index: AQHSfpgp1WotbK9CCkaf12wmhmLfBKFZseoAgAGayTA=
Date: Mon, 6 Feb 2017 03:02:12 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810CD4D95@SHSMSX103.ccr.corp.intel.com>
References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com>
 <1486179375-133509-1-git-send-email-jingjing.wu@intel.com>
 <1486179375-133509-3-git-send-email-jingjing.wu@intel.com>
 <be763f08-23ad-d2a9-cea3-1209eb2c6d6c@intel.com>
In-Reply-To: <be763f08-23ad-d2a9-cea3-1209eb2c6d6c@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx
 flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 03:02:16 -0000

>=20
> Functionally will be same, but what do you think about following, to make
> easy to see what define adds:
>=20
> +#define I40E_TX_OFFLOAD_MASK (		 \
> +		PKT_TX_IP_CKSUM |	 \
> +		PKT_TX_IPV4 |		 \
> +		PKT_TX_IPV6 |		 \
> +		PKT_TX_L4_MASK |	 \
> +		PKT_TX_OUTER_IP_CKSUM |	 \
> +		PKT_TX_OUTER_IPV4 |	 \
> +		PKT_TX_OUTER_IPV6 |	 \
>=20
> +#ifdef RTE_LIBRTE_IEEE1588
> +		PKT_TX_IEEE1588_TMST |	 \
> +#endif
>=20
> +		PKT_TX_TCP_SEG |	 \
> +		PKT_TX_QINQ_PKT |	 \
> +		PKT_TX_VLAN_PKT |	 \
> +		PKT_TX_TUNNEL_MASK)
>=20

Hi, Ferruh

As I know, the above change is incorrect in C code. We cannot use #ifdef  #=
endif inside #define

Thanks
Jingjing