From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 56AE4376C for ; Tue, 7 Feb 2017 03:30:21 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 06 Feb 2017 18:30:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="62646133" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 06 Feb 2017 18:30:20 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Feb 2017 18:30:19 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Tue, 7 Feb 2017 10:30:16 +0800 From: "Wu, Jingjing" To: Olivier Matz CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags Thread-Index: AQHSfpgp1WotbK9CCkaf12wmhmLfBKFZseoAgAGayTD///eOAIABkreA Date: Tue, 7 Feb 2017 02:30:15 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CD55C7@SHSMSX103.ccr.corp.intel.com> References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-3-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F810CD4D95@SHSMSX103.ccr.corp.intel.com> <20170206112838.528745e8@platinum> In-Reply-To: <20170206112838.528745e8@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 02:30:21 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Monday, February 6, 2017 6:29 PM > To: Wu, Jingjing > Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Helin > > Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported= Tx > flags >=20 > On Mon, 6 Feb 2017 03:02:12 +0000, "Wu, Jingjing" > wrote: > > > > > > Functionally will be same, but what do you think about following, to > > > make easy to see what define adds: > > > > > > +#define I40E_TX_OFFLOAD_MASK ( \ > > > + PKT_TX_IP_CKSUM | \ > > > + PKT_TX_IPV4 | \ > > > + PKT_TX_IPV6 | \ > > > + PKT_TX_L4_MASK | \ > > > + PKT_TX_OUTER_IP_CKSUM | \ > > > + PKT_TX_OUTER_IPV4 | \ > > > + PKT_TX_OUTER_IPV6 | \ > > > > > > +#ifdef RTE_LIBRTE_IEEE1588 > > > + PKT_TX_IEEE1588_TMST | \ > > > +#endif > > > > > > + PKT_TX_TCP_SEG | \ > > > + PKT_TX_QINQ_PKT | \ > > > + PKT_TX_VLAN_PKT | \ > > > + PKT_TX_TUNNEL_MASK) > > > > > > > Hi, Ferruh > > > > As I know, the above change is incorrect in C code. We cannot use > > #ifdef #endif inside #define > > > > Thanks > > Jingjing >=20 >=20 > You can do: >=20 > #ifdef RTE_LIBRTE_IEEE1588 > #define I40_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST #else #define > I40_TX_IEEE1588_TMST 0 #endif >=20 > #define I40E_TX_OFFLOAD_MASK ( \ > I40_TX_IEEE1588_TMST | \ > PKT_TX_IP_CKSUM | \ > ... >=20 Thanks for the suggestion. >=20 > Regards, > Olivier