From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 983A39E3 for ; Tue, 7 Feb 2017 03:30:58 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 06 Feb 2017 18:30:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="62646363" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 06 Feb 2017 18:30:57 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Feb 2017 18:30:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Feb 2017 18:30:56 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Tue, 7 Feb 2017 10:30:54 +0800 From: "Wu, Jingjing" To: Olivier Matz CC: "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags Thread-Index: AQHSfpgp1WotbK9CCkaf12wmhmLfBKFbQ7GAgAGTXUA= Date: Tue, 7 Feb 2017 02:30:53 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CD55DB@SHSMSX103.ccr.corp.intel.com> References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-3-git-send-email-jingjing.wu@intel.com> <20170206112637.5a011a7a@platinum> In-Reply-To: <20170206112637.5a011a7a@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 02:30:59 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Monday, February 6, 2017 6:27 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Helin ; Ananyev, > Konstantin ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported= Tx > flags >=20 > Hi Jingjing, >=20 > On Sat, 4 Feb 2017 11:36:12 +0800, Jingjing Wu > wrote: > > Some Tx offload flags are missed in bitmask of all supported packet Tx > > flags by i40e. > > This patch fixes it. >=20 > Could you detail which flag was missing? > Is it PKT_TX_TUNNEL_MASK? > If yes, shouldn't we have a "Fixes:" line? >=20 > I think most of the patchset should be merged in one patch, because > changing only the mbuf part (PKT_TX_OFFLOAD_MASK) would break the > drivers that checks the offload bits at init, and this is not suitable, e= specially if > we want to be able to do git bisect. >=20 >=20 > My suggestion is to have: >=20 > 1- fix i40 (add missing tunnel mask?) > 2- fix missing MACSET in TX_OFFLOAD_MASK > 3- change TX_OFFLOAD_MASK to include all flags (this impacts all > drivers using TX_OFFLOAD_MASK) >=20 > OK. Will change according to your suggestion. It's clearer. Thanks Jingjing