From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Helin" <helin.zhang@intel.com>
Subject: Re: [dpdk-dev] disable i40e vf vlan stripping
Date: Wed, 29 Mar 2017 02:53:15 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D19603@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170328172943.7b157ef4@platinum>
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Tuesday, March 28, 2017 11:30 PM
> To: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: disable i40e vf vlan stripping
>
> Hi i40e maintainers,
>
> I have the following configuration:
> - host runs with Linux pf i40e driver
> - guest runs with DPDK vf i40e driver
>
> I send a vlan packet from the host to the guest.
> On the guest, I start testpmd with --disable-hw-vlan-strip.
>
> When I receive the packet on the guest, it has the PKT_RX_VLAN_STRIPPED flag
> although I'm not asking for it. From what I understand, it is not possible to
> disable vlan stripping when using a Linux PF driver.
>
> Since the i40evf DPDK driver does not behave like what the application asks for,
> I think it should be fixed. What do you think about re-adding the vlan in
> software when dev_conf->rxmode.hw_vlan_strip == 0 ?
>
> The other alternative would be to forbid this configuration and return an error.
>
We faced the same issue with hw_crc_strip, and now the code is consider it as an error.
The issue is hw_vlan_strip/hw_crc_strip mode is inconsistent between VF and PF.
Evne I think it should not be an error to block the VF start up. But I'm fine if you think it is an error.
The ideal way maybe the capability negotiate between VF and PF. Let's think about it.
Thanks
Jingjing
Thanks
Jingjing
next prev parent reply other threads:[~2017-03-29 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 15:29 Olivier Matz
2017-03-29 2:53 ` Wu, Jingjing [this message]
2017-03-29 7:20 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D19603@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).