From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A22B728F3 for ; Wed, 29 Mar 2017 04:53:18 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 28 Mar 2017 19:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,239,1486454400"; d="scan'208";a="81728011" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 28 Mar 2017 19:53:17 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Mar 2017 19:53:17 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Mar 2017 19:53:17 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.42]) with mapi id 14.03.0248.002; Wed, 29 Mar 2017 10:53:15 +0800 From: "Wu, Jingjing" To: Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: disable i40e vf vlan stripping Thread-Index: AQHSp9gpcidbbMZFRUKW3buP4csZo6GrHWgg Date: Wed, 29 Mar 2017 02:53:15 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D19603@SHSMSX103.ccr.corp.intel.com> References: <20170328172943.7b157ef4@platinum> In-Reply-To: <20170328172943.7b157ef4@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] disable i40e vf vlan stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 02:53:19 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Tuesday, March 28, 2017 11:30 PM > To: dev@dpdk.org; Zhang, Helin ; Wu, Jingjing > > Subject: disable i40e vf vlan stripping >=20 > Hi i40e maintainers, >=20 > I have the following configuration: > - host runs with Linux pf i40e driver > - guest runs with DPDK vf i40e driver >=20 > I send a vlan packet from the host to the guest. > On the guest, I start testpmd with --disable-hw-vlan-strip. >=20 > When I receive the packet on the guest, it has the PKT_RX_VLAN_STRIPPED f= lag > although I'm not asking for it. From what I understand, it is not possibl= e to > disable vlan stripping when using a Linux PF driver. >=20 > Since the i40evf DPDK driver does not behave like what the application as= ks for, > I think it should be fixed. What do you think about re-adding the vlan in > software when dev_conf->rxmode.hw_vlan_strip =3D=3D 0 ? >=20 > The other alternative would be to forbid this configuration and return an= error. >=20 We faced the same issue with hw_crc_strip, and now the code is consider it = as an error. The issue is hw_vlan_strip/hw_crc_strip mode is inconsistent between VF and= PF. Evne I think it should not be an error to block the VF start up. But I'm fi= ne if you think it is an error. The ideal way maybe the capability negotiate between VF and PF. Let's think= about it. Thanks Jingjing Thanks Jingjing