From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 25D3E10BAC
 for <dev@dpdk.org>; Thu, 30 Mar 2017 09:02:51 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 00:02:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,245,1486454400"; d="scan'208";a="949695085"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga003.jf.intel.com with ESMTP; 30 Mar 2017 00:02:49 -0700
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 30 Mar 2017 00:02:49 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 30 Mar 2017 00:02:49 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.212]) with mapi id 14.03.0248.002;
 Thu, 30 Mar 2017 15:02:38 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhao1, Wei" <wei.zhao1@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 2/3] net/i40e: implement device reset on
 port
Thread-Index: AQHSp5ueYf5GKLRcIEyyJVcVbZB8daGs7oqg
Date: Thu, 30 Mar 2017 07:02:38 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810D1B274@SHSMSX103.ccr.corp.intel.com>
References: <1490688547-4831-1-git-send-email-wei.zhao1@intel.com>
 <1490688547-4831-3-git-send-email-wei.zhao1@intel.com>
In-Reply-To: <1490688547-4831-3-git-send-email-wei.zhao1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/i40e: implement device reset on
 port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 07:02:52 -0000

Looks good, just minor comment

> +static int
> +i40evf_reset_dev(struct rte_eth_dev *dev) {
> +	struct i40e_adapter *adapter =3D
> +		I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> +
> +	adapter->reset_flag =3D 1;
> +	i40evf_store_before_reset(dev);
> +
> +	i40evf_dev_close(dev);
> +	PMD_DRV_LOG(DEBUG, "i40evf dev close complete");
> +
> +	i40evf_dev_uninit(dev);
> +	PMD_DRV_LOG(DEBUG, "i40evf dev detached");
> +
> +	memset(dev->data->dev_private, 0,
> +	       (uint64_t)&adapter->reset_flag - (uint64_t)adapter);
You can use offset() instead.