From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 5E570559C
 for <dev@dpdk.org>; Fri, 28 Apr 2017 10:05:16 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga104.jf.intel.com with ESMTP; 28 Apr 2017 01:05:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="81685773"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga004.jf.intel.com with ESMTP; 28 Apr 2017 01:05:15 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 28 Apr 2017 01:05:15 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 28 Apr 2017 01:05:14 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002;
 Fri, 28 Apr 2017 16:05:12 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] net/i40e: add check for ethertype filter
Thread-Index: AQHSv0ZIDvkxfqteF0Sy9A8nk1t2yaHabYbA
Date: Fri, 28 Apr 2017 08:05:12 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810D59FCA@SHSMSX103.ccr.corp.intel.com>
References: <1493290938-80198-1-git-send-email-beilei.xing@intel.com>
In-Reply-To: <1493290938-80198-1-git-send-email-beilei.xing@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add check for ethertype filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Apr 2017 08:05:16 -0000



> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, April 27, 2017 7:02 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/i40e: add check for ethertype filter
>=20
> LLDP rule is not supported in ethertype filter.
>=20
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 1 +
>  lib/librte_net/rte_ether.h   | 1 +
>  2 files changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c =
index
> 0a0181f..24e1c65 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -608,6 +608,7 @@ i40e_flow_parse_ethertype_pattern(struct rte_eth_dev
> *dev,
>=20
>  			if (filter->ether_type =3D=3D ETHER_TYPE_IPv4 ||
>  			    filter->ether_type =3D=3D ETHER_TYPE_IPv6 ||
> +			    filter->ether_type =3D=3D ETHER_TYPE_LLDP ||
>  			    filter->ether_type =3D=3D outer_tpid) {
>  				rte_flow_error_set(error, EINVAL,
>=20
> RTE_FLOW_ERROR_TYPE_ITEM,
> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h inde=
x
> ff3d065..c448bf3 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -333,6 +333,7 @@ struct vxlan_hdr {
>  #define ETHER_TYPE_1588 0x88F7 /**< IEEE 802.1AS 1588 Precise Time
> Protocol. */  #define ETHER_TYPE_SLOW 0x8809 /**< Slow protocols (LACP
> and Marker). */  #define ETHER_TYPE_TEB  0x6558 /**< Transparent Ethernet
> Bridging. */
> +#define ETHER_TYPE_LLDP 0x88CC /**< LLDP Protocol. */
>=20
>  #define ETHER_VXLAN_HLEN (sizeof(struct udp_hdr) + sizeof(struct vxlan_h=
dr))
> /**< VXLAN tunnel header length. */

Acked-by: Jingjing Wu <jingjing.wu@intel.com>

> --
> 2.5.5