From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C29A29E3 for ; Fri, 28 Apr 2017 10:30:45 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 01:30:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="94878368" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 28 Apr 2017 01:30:28 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 01:30:27 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 01:30:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 16:30:25 +0800 From: "Wu, Jingjing" To: "Pei, Yulong" , "dev@dpdk.org" CC: "thomas@monjalon.net" Thread-Topic: [PATCH v4] app/testpmd: initialize port_numa and ring_numa Thread-Index: AQHSv/Z6HvTpiV38vEOfsQoHbxKck6HacxEQ Date: Fri, 28 Apr 2017 08:30:25 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D5A0CA@SHSMSX103.ccr.corp.intel.com> References: <1493344915-127542-1-git-send-email-yulong.pei@intel.com> In-Reply-To: <1493344915-127542-1-git-send-email-yulong.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: initialize port_numa and ring_numa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 08:30:46 -0000 > -----Original Message----- > From: Pei, Yulong > Sent: Friday, April 28, 2017 10:02 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; thomas@monjalon.net > Subject: [PATCH v4] app/testpmd: initialize port_numa and ring_numa >=20 > Previous numa_support =3D 0 by default, it need to add --numa to testpmd > command line to enable numa, so port_numa and ring_numa were initialized = at > function launch_args_parse(), now testpmd change numa_support =3D 1 as de= fault, > so port_numa and ring_numa also need to initialize by default, otherwise = port- > >socket_id will be probed to wrong value. >=20 > Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") >=20 > Signed-off-by: Yulong Pei You forgot "fix" in title if the patch is fixing a problem. Anyway, the change is OK. Acked-by: Jingjing Wu