From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 834A63B5 for ; Mon, 8 May 2017 08:17:57 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 07 May 2017 23:17:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,308,1491289200"; d="scan'208";a="96910151" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 07 May 2017 23:17:55 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 May 2017 23:17:55 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 7 May 2017 23:17:55 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Mon, 8 May 2017 14:17:40 +0800 From: "Wu, Jingjing" To: "Wu, Jingjing" , Thomas Monjalon , "Dai, Wei" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "harish.patil@cavium.com" , "rasesh.mody@cavium.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "Zhang, Helin" , "Ananyev, Konstantin" , "Chen, Jing D" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Richardson, Bruce" , "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" Thread-Topic: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs Thread-Index: AQHSxTlTRKzwLwFVpUiLqBpmeylPjKHlRfyAgARcd2CAAFgc0A== Date: Mon, 8 May 2017 06:17:40 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D63D99@SHSMSX103.ccr.corp.intel.com> References: <1493729065-17090-1-git-send-email-wei.dai@intel.com> <1493944802-52943-1-git-send-email-wei.dai@intel.com> <1493944802-52943-4-git-send-email-wei.dai@intel.com> <4247821.b6tKX1pDh8@xps> <9BB6961774997848B5B42BEC655768F810D638DE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D638DE@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2017 06:17:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Monday, May 8, 2017 9:02 AM > To: Thomas Monjalon ; Dai, Wei > Cc: dev@dpdk.org; Lu, Wenzhuo ; > harish.patil@cavium.com; rasesh.mody@cavium.com; > stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; Zhang, Helin > ; Ananyev, Konstantin > ; Chen, Jing D ; > adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; Richardson, Bruce > ; yuanhan.liu@linux.intel.com; > maxime.coquelin@redhat.com; shepard.siegel@atomicrules.com; > ed.czeck@atomicrules.com; john.miller@atomicrules.com > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add > many MAC addrs >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Friday, May 5, 2017 10:24 PM > > To: Dai, Wei > > Cc: dev@dpdk.org; Lu, Wenzhuo ; > > harish.patil@cavium.com; rasesh.mody@cavium.com; > > stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; Zhang, Helin > > ; Ananyev, Konstantin > > ; Wu, Jingjing ; > > Chen, Jing D ; adrien.mazarguil@6wind.com; > > nelio.laranjeiro@6wind.com; Richardson, Bruce > > ; yuanhan.liu@linux.intel.com; > > maxime.coquelin@redhat.com; shepard.siegel@atomicrules.com; > > ed.czeck@atomicrules.com; john.miller@atomicrules.com > > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to > > add many MAC addrs > > > > 05/05/2017 02:40, Wei Dai: > > > This patch is added to introduce a testpmd command which is used to > > > add more than one MAC addresses one time. > > > This command can simplify the test for the change where the type of > > > return value of adding MAC address. > > > Normally a MAC address may fails to be added only after many MAC > > > addresses have been added. > > > Without this command, a tester may only trigger failed MAC address > > > by running many times of testpmd command 'mac_addr add' . > > > > > > Signed-off-by: Wei Dai > > > --- > > > app/test-pmd/cmdline.c | 55 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > This patch has not been reviewed. > > It is not a fix and I am not sure it is needed. >=20 > The same doubt, what is this relationship with your fix in Patch 1/3? >=20 If it is only for testing for special case, and it can be done through calling 'mac_addr add' by multi times. I'd like to Nack it. Thanks Jingjing