From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 7AB522952;
 Tue,  9 May 2017 02:43:48 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga105.fm.intel.com with ESMTP; 08 May 2017 17:43:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,311,1491289200"; d="scan'208";a="97315670"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga005.jf.intel.com with ESMTP; 08 May 2017 17:43:46 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 8 May 2017 17:43:46 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 8 May 2017 17:43:46 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002;
 Tue, 9 May 2017 08:43:44 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v2] app/testpmd: support non contiguous socket ids
Thread-Index: AQHSxBNt8Bgnb7B1MEyktyKgEDyQkKHmhiGggAFbn4CAAcDRUIAAkjoAgAD9bOA=
Date: Tue, 9 May 2017 00:43:44 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810D64D17@SHSMSX103.ccr.corp.intel.com>
References: <20170503134429.22723-1-shahafs@mellanox.com>
 <9BB6961774997848B5B42BEC655768F810D624B2@SHSMSX103.ccr.corp.intel.com>
 <AM4PR05MB150554A6988276FBE9467723C3E90@AM4PR05MB1505.eurprd05.prod.outlook.com>
 <9BB6961774997848B5B42BEC655768F810D6383D@SHSMSX103.ccr.corp.intel.com>
 <AM4PR05MB15051AB8F84C4E8C744A7B17C3EE0@AM4PR05MB1505.eurprd05.prod.outlook.com>
In-Reply-To: <AM4PR05MB15051AB8F84C4E8C744A7B17C3EE0@AM4PR05MB1505.eurprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous
	socket ids
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 May 2017 00:43:49 -0000

>=20
> Right, i prefer the following though, what do you think?
>=20
>        for (i =3D 0; i < RTE_MAX_LCORE; i++) {
>                 sock_num =3D rte_lcore_to_socket_id(i);
>                 if (new_socket_id(sock_num)) {
>                         if (num_sockets >=3D RTE_MAX_NUMA_NODES) {
>                                 rte_exit(EXIT_FAILURE,
>                                          "Total sockets greater than %u\n=
",
>                                          RTE_MAX_NUMA_NODES);
>                         }
>                         socket_ids[num_sockets++] =3D sock_num;
>                 }
>=20
That looks good :)

> > One more thing, if this patch is fixing a bug, I think "fix" should be
> > added in title.
>=20
> OK, I guess I can change the commit title and message.
>=20
> BTW note that there is a V3 with Thomas requested changes.
> If we agree on above I can submit a v4 with the last updates.
>=20
>
OK.
=20
Thanks
Jingjing