DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] i40e: pci probe fails when using one bogus sfp
Date: Mon, 12 Jun 2017 16:23:47 +0000	[thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810DA1FAE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170612114530.0eab4314@platinum>

HI, Olivier

> Thank you for your quick answer.
> 
> Yes, the pci probing continues for the other ports even if one port
> failed (since v17.05, commit 10f6c93cea).
> 
> But I find a bit strange to have this check about the SFP in the
> PCI probing function instead of having it the port initialization
> function. My understanding is the SFP check is not related to PCI
> probing. Is it consistent with other drivers?
>
Could your customer help to check what is the exactly error code is by
Checking the "hw->aq.asq_last_status" when eth_i40e_dev_init() fails.

Yes, it seems better PHY init fails doesn't block PCI probe. Just compared with i40e
Kernel version, PHY init fails doesn't block CPI probe. And there is watchdog task to
Check the PHY status. But DPDK is polling mode, If PCI probe fails, PCI probe continues,
then application need poll PHY status to support SFP change.

And I also checked ixgbe driver, it seems phy init is done at probe time.
In my opinion, dev_start and dev_stop is meaning ready for receiving and transmitting
packets, it may not be suitable to put it in the start/stop phase.


> 
> Regards
> Olivier

  parent reply	other threads:[~2017-06-12 16:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  9:29 Olivier Matz
2017-06-08 10:01 ` Bruce Richardson
2017-06-08 10:13   ` Olivier Matz
2017-06-12  8:45     ` Xing, Beilei
2017-06-12  9:45       ` Olivier Matz
2017-06-12 15:53         ` Wu, Jingjing
2017-06-12 16:25           ` Wu, Jingjing
2017-06-12 16:23         ` Wu, Jingjing [this message]
2017-06-13  8:27           ` Olivier MATZ
2017-06-13 14:14             ` Wu, Jingjing
2017-06-15  9:03               ` Olivier MATZ
2017-06-15  9:08                 ` [dpdk-dev] [PATCH] net/i40e: avoid PCI probing failure when using " Olivier Matz
2017-06-23  9:25                   ` Wu, Jingjing
2017-06-23 10:11                     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F810DA1FAE@SHSMSX103.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).