From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4DA3C3DC for ; Mon, 12 Jun 2017 18:24:11 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 12 Jun 2017 09:24:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,334,1493708400"; d="scan'208";a="98514692" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2017 09:23:51 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 09:23:51 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 09:23:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by shsmsx102.ccr.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002; Tue, 13 Jun 2017 00:23:48 +0800 From: "Wu, Jingjing" To: Olivier Matz , "Xing, Beilei" CC: "Richardson, Bruce" , "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] i40e: pci probe fails when using one bogus sfp Thread-Index: AQHS4Dm+UFJsHZxugEO6Kasnp7QyaaIaNfMAgAADUwCABjC3gIAAELQAgADtBOA= Date: Mon, 12 Jun 2017 16:23:47 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810DA1FAE@SHSMSX103.ccr.corp.intel.com> References: <20170608112917.22fb51eb@platinum> <20170608100154.GA56168@bricha3-MOBL3.ger.corp.intel.com> <20170608121348.5c2f538a@platinum> <94479800C636CB44BD422CB454846E0131FC734C@SHSMSX101.ccr.corp.intel.com> <20170612114530.0eab4314@platinum> In-Reply-To: <20170612114530.0eab4314@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] i40e: pci probe fails when using one bogus sfp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 16:24:11 -0000 HI, Olivier > Thank you for your quick answer. >=20 > Yes, the pci probing continues for the other ports even if one port > failed (since v17.05, commit 10f6c93cea). >=20 > But I find a bit strange to have this check about the SFP in the > PCI probing function instead of having it the port initialization > function. My understanding is the SFP check is not related to PCI > probing. Is it consistent with other drivers? > Could your customer help to check what is the exactly error code is by Checking the "hw->aq.asq_last_status" when eth_i40e_dev_init() fails. Yes, it seems better PHY init fails doesn't block PCI probe. Just compared = with i40e Kernel version, PHY init fails doesn't block CPI probe. And there is watchd= og task to Check the PHY status. But DPDK is polling mode, If PCI probe fails, PCI pro= be continues, then application need poll PHY status to support SFP change. And I also checked ixgbe driver, it seems phy init is done at probe time. In my opinion, dev_start and dev_stop is meaning ready for receiving and tr= ansmitting packets, it may not be suitable to put it in the start/stop phase. >=20 > Regards > Olivier