From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 8550E2BDF
 for <dev@dpdk.org>; Tue, 20 Jun 2017 04:18:14 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Jun 2017 19:18:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,363,1493708400"; d="scan'208";a="116423214"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by fmsmga005.fm.intel.com with ESMTP; 19 Jun 2017 19:18:13 -0700
Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 19 Jun 2017 19:18:13 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Mon, 19 Jun 2017 19:18:13 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002;
 Tue, 20 Jun 2017 10:18:10 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Mrzyglod, DanielX T"
 <danielx.t.mrzyglod@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 2/2] app/testpmd: add support for different
 aggregation mode in IEEE802.3ad bonding
Thread-Index: AQHS1i5h6BzAreab+kirpbOKHR02n6ItKbrQ
Date: Tue, 20 Jun 2017 02:18:10 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810DAA59F@SHSMSX103.ccr.corp.intel.com>
References: <20170526143528.16533-1-danielx.t.mrzyglod@intel.com>
 <20170526143528.16533-3-danielx.t.mrzyglod@intel.com>
In-Reply-To: <20170526143528.16533-3-danielx.t.mrzyglod@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add support for
	different	aggregation mode in IEEE802.3ad bonding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 02:18:15 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
> Sent: Friday, May 26, 2017 10:35 PM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: add support for different
> aggregation mode in IEEE802.3ad bonding
>=20
> This patch add support for different aggregator modes in similar manner t=
hat is
> provided in linux kernel.
>=20
> testpmd> set bonding agg_mode <port_id> <agg_name> show bonding config
> testpmd> <port_id>
>=20
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>


Here are my comments:

1. title looks too long
2. New commands or update need to be added to help display located at cmd_h=
elp_long_parsed.
3. You also need to update the testpmd doc.

Thanks
Jingjing