From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E9CD05323 for ; Thu, 22 Jun 2017 03:13:27 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 21 Jun 2017 18:13:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,371,1493708400"; d="scan'208";a="100296332" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 21 Jun 2017 18:13:24 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Jun 2017 18:13:23 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Jun 2017 18:13:22 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 22 Jun 2017 09:13:21 +0800 From: "Wu, Jingjing" To: Vasily Philipov , "dev@dpdk.org" CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter Thread-Index: AQHS3Td86fEjqyixiUGCJgv9Wj6fSqItDLyAgAGYeICAAYl94A== Date: Thu, 22 Jun 2017 01:13:21 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com> References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <96c3dca8015a755afb37bf35ae85e6fa16282c0c.1496583000.git.vasilyf@mellanox.com> <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 01:13:28 -0000 > -----Original Message----- > From: Vasily Philipov [mailto:vasilyf@mellanox.com] > Sent: Wednesday, June 21, 2017 5:44 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: Adrien Mazarguil ; N=E9lio Laranjeiro > > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode > parameter >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing [mailto:jingjing.wu@intel.com] > > Sent: Tuesday, June 20, 2017 04:27 > > To: Vasily Philipov ; dev@dpdk.org > > Cc: Adrien Mazarguil ; N=E9lio Laranjeiro > > > > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode > > parameter > > > > > > > +/* > > > * Avoids to check link status when starting/stopping a port. > > > */ > > > uint8_t no_link_check =3D 0; /* check by default */ @@ -1422,6 > > > +1427,15 @@ static void eth_event_callback(uint8_t port_id, > > > if (port->need_reconfig > 0) { > > > port->need_reconfig =3D 0; > > > > > > + if (isolated_mode) { > > > + int ret =3D port_flow_isolate(pi, 1); > > > + if (ret) { > > > + printf("Failed to apply isolated" > > > + " mode on port %d\n", pi); > > > + return -1; > > > + } > > > + } > > > + > > Should it block the app startup if isolated-mode setting fails? >=20 > if isolated mode cannot be enabled on any port, that port cannot be initi= alized > and that causes testpmd to quit, at least it won't go against the user's = wishes If so, I prefer the isolated_mode to be port's argument but not global one. How about to add a command to configure the isolate mode?