From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 07CF92BE1 for ; Thu, 29 Jun 2017 07:52:27 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 22:52:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,279,1496127600"; d="scan'208";a="120183399" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 28 Jun 2017 22:52:16 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 22:52:16 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 22:52:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Thu, 29 Jun 2017 13:52:13 +0800 From: "Wu, Jingjing" To: Thomas Monjalon CC: "dev@dpdk.org" , Vasily Philipov , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter Thread-Index: AQHS3Td86fEjqyixiUGCJgv9Wj6fSqItDLyAgAGYeICAAYl94IAHz5OAgAN+3hA= Date: Thu, 29 Jun 2017 05:52:13 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810DB5D34@SHSMSX103.ccr.corp.intel.com> References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com> <3515786.3Gc2XbLCYg@xps> In-Reply-To: <3515786.3Gc2XbLCYg@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 05:52:28 -0000 > > > > Should it block the app startup if isolated-mode setting fails? > > > > > > if isolated mode cannot be enabled on any port, that port cannot be > > > initialized and that causes testpmd to quit, at least it won't go > > > against the user's wishes > > > > If so, I prefer the isolated_mode to be port's argument but not global = one. > > How about to add a command to configure the isolate mode? >=20 > There is already a command to configure isolate mode per-port: > http://dpdk.org/patch/25320 > http://dpdk.org/doc/guides/testpmd_app_ug/testpmd_funcs.html#flow > -syntax >=20 > I think it does not make sense to replicate this per-port command in comm= and > line parameters. > All the other parameters are global: > http://dpdk.org/doc/guides/testpmd_app_ug/run_app.html#testpmd- > command-line-options > The idea here is to have a global isolate mode with a general option. OK. Thanks Then I'm fine with it.