From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3296923C for ; Fri, 21 Jul 2017 04:26:01 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jul 2017 19:26:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,387,1496127600"; d="scan'208";a="1153690743" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 20 Jul 2017 19:26:00 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Jul 2017 19:26:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 21 Jul 2017 10:25:58 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix link down and negotiation issue Thread-Index: AQHTATR+fO9SC7GTTEaNzphR3wIDcqJdiE1g Date: Fri, 21 Jul 2017 02:25:58 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810DCD3C2@SHSMSX103.ccr.corp.intel.com> References: <1500540302-84503-1-git-send-email-jia.guo@intel.com> In-Reply-To: <1500540302-84503-1-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix link down and negotiation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2017 02:26:02 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Thursday, July 20, 2017 4:45 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/i40e: fix link down and negotiation issue >=20 > Enable the functions set link down and set link up in i40e by check phy_t= ype, > and fix the issue of auto negotiation failed in XXV710 when bind kernel d= river > after unbind from dpdk driver by modify the speed setting distinguish fro= m set > link up and down. With this fix, if unbind dpdk to bind kernel driver, no= need to > set auto negotiation and ifconfi up anymore, remove the part from doc. >=20 > Fixes: ca7e599d4506 ("net/i40e: fix link management") > Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround") > Fixes: 6e145fcc754b ("6e145fcc754b5e79167") What is this? Need to add title. How about to CC stable@dpdk.org? > enum i40e_status_code status; > struct i40e_aq_get_phy_abilities_resp phy_ab; > struct i40e_aq_set_phy_config phy_conf; > + enum i40e_aq_phy_type cnt; > + __le32 phy_type_mask =3D 0; Please define it as unit32_t, and use cpu_to_le32 when assigning,