From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D92A23195 for ; Mon, 25 Sep 2017 04:43:08 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 19:43:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,434,1500966000"; d="scan'208";a="315712668" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2017 19:43:07 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 19:43:07 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 19:43:06 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 10:43:04 +0800 From: "Wu, Jingjing" To: "Hunt, David" , "dev@dpdk.org" CC: "Hunt, David" , "Marjanovic, Nemanja" , "Sexton, Rory" Thread-Topic: [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id to PF Id Thread-Index: AQHTHbuqJKqk2w8ihkCrzw/lqIECCKLFE5DA Date: Mon, 25 Sep 2017 02:43:04 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E7C7D3@SHSMSX103.ccr.corp.intel.com> References: <1503676941-80981-1-git-send-email-david.hunt@intel.com> <1503676941-80981-2-git-send-email-david.hunt@intel.com> In-Reply-To: <1503676941-80981-2-git-send-email-david.hunt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id to PF Id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 02:43:09 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt > Sent: Saturday, August 26, 2017 12:02 AM > To: dev@dpdk.org > Cc: Hunt, David ; Marjanovic, Nemanja > ; Sexton, Rory > Subject: [dpdk-dev] [PATCH v1 01/10] net/i40e: add API to convert VF Id t= o PF Id >=20 > Need a way to convert a vf id to a pf id on the host so as to query the p= f for > relevant statistics which are used for the frequency changes in the > vm_power_manager app. Used when profiles are passed down from the guest > to the host, allowing the host to map the vfs to pfs. >=20 > Signed-off-by: Nemanja Marjanovic > Signed-off-by: Rory Sexton > Signed-off-by: David Hunt > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > drivers/net/i40e/i40e_rxtx.c | 27 +++++++++++++++++++++++++++ > drivers/net/i40e/i40e_rxtx.h | 1 + > lib/librte_ether/rte_ethdev.h | 11 +++++++++++ > 4 files changed, 40 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 5f26e24..8fb67d8 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -445,6 +445,7 @@ static const struct rte_pci_id pci_id_i40e_map[] =3D = { }; >=20 > static const struct eth_dev_ops i40e_eth_dev_ops =3D { > + .vfid_to_pfid =3D i40e_vf_mac_to_vsi, > .dev_configure =3D i40e_dev_configure, > .dev_start =3D i40e_dev_start, > .dev_stop =3D i40e_dev_stop, > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > d42c23c..1379d5e 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -806,6 +806,33 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > return nb_rx; > } >=20 > +uint64_t > +i40e_vf_mac_to_vsi(struct rte_eth_dev *dev, uint64_t vfid) { > + struct ether_addr *vf_mac_addr =3D (struct ether_addr *)&vfid; > + struct ether_addr *mac; > + struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > + int vsi_id =3D 0, i, x; > + struct i40e_pf_vf *vf; > + uint16_t vf_num =3D pf->vf_num; > + > + for (x =3D 0; x < vf_num; x++) { > + int mac_addr_matches =3D 1; > + vf =3D &pf->vfs[x]; > + mac =3D &vf->mac_addr; > + > + for (i =3D 0; i < ETHER_ADDR_LEN; i++) { > + if (mac->addr_bytes[i] !=3D vf_mac_addr->addr_bytes[i]) > + mac_addr_matches =3D 0; > + } > + if (mac_addr_matches) { > + vsi_id =3D vf->vsi->vsi_id; > + return vsi_id; > + } vsi and vsi_id is not a common concept in API level. How about just return vf_id and rename the function like i40e_query_vf_id_b= y_mac? In i40e driver, we can get the vsi_id by vf_id. > + } > + > + return -1; It's an ops to API, you need to use error code but not -1. Thanks Jingjing