From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7F8213256 for ; Thu, 5 Oct 2017 05:09:30 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 20:09:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,479,1500966000"; d="scan'208";a="159026826" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 04 Oct 2017 20:09:28 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 4 Oct 2017 20:09:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 4 Oct 2017 20:09:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Thu, 5 Oct 2017 11:09:26 +0800 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [PATCH v7 6/8] net/i40e: add FDIR support for GTP-C and GTP-U Thread-Index: AQHTOTrj4iJNTAPjGU6bwQJ3Dr82i6LUm0rw Date: Thu, 5 Oct 2017 03:09:25 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E89C9A@SHSMSX103.ccr.corp.intel.com> References: <1506662342-18966-1-git-send-email-beilei.xing@intel.com> <1506700252-34949-1-git-send-email-beilei.xing@intel.com> <1506700252-34949-7-git-send-email-beilei.xing@intel.com> In-Reply-To: <1506700252-34949-7-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTI1NTk4NGUtYjAxYS00YmNjLTkyYzAtNGZlYTJjNDM2OWEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1hVmdFTENVTXZSTzdjUmllRnd5WjJzRGE5bFJ3eGtuN3FEMnRoaW92OEk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 6/8] net/i40e: add FDIR support for GTP-C and GTP-U X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 03:09:30 -0000 > @@ -975,27 +1003,30 @@ i40e_flow_fdir_fill_eth_ip_head(const struct i40e_= fdir_input > *fdir_input, > raw_pkt +=3D sizeof(uint16_t); > len +=3D sizeof(uint16_t); >=20 > - switch (fdir_input->pctype) { > - case I40E_FILTER_PCTYPE_L2_PAYLOAD: > + if (is_customized_pctype) { > + cus_pctype =3D i40e_flow_fdir_find_customized_pctype(pf, pctype); > + if (!cus_pctype) > + PMD_DRV_LOG(ERR, "unknown pctype %u.", > + fdir_input->pctype); Doesn't return here? If it is impossible cus_pctype is NULL, the check is unnecessary. Because you used the cus_ptype below. Thanks Jingjing