From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 369882BAA for ; Thu, 5 Oct 2017 10:35:38 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 01:35:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,480,1500966000"; d="scan'208";a="319824959" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2017 01:35:37 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Oct 2017 01:35:37 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Thu, 5 Oct 2017 16:35:35 +0800 From: "Wu, Jingjing" To: Stephen Hemminger , "Li, Xiaoyun" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app Thread-Index: AQHTOZAH6oOGuT1KC0KOnT34Bho7EqLOuvMAgAY6boA= Date: Thu, 5 Oct 2017 08:35:35 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E8A04E@SHSMSX103.ccr.corp.intel.com> References: <1506565888-194214-1-git-send-email-xiaoyun.li@intel.com> <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> <20171001102410.3c928ad5@xeon-e3> In-Reply-To: <20171001102410.3c928ad5@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGZhMzlkNjktYTNlNC00NGYwLWJlZmQtMjIxNWQxMDQ0ZDQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdYaGJ5UFdRSTBsUUNiSXFRTXEwVkswRGJHZ3dhZ3VLZGpSTnZoRkdXYmc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 08:35:38 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, October 2, 2017 1:24 AM > To: Li, Xiaoyun > Cc: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments wh= en start app >=20 > On Sat, 30 Sep 2017 09:59:08 +0800 > Xiaoyun Li wrote: >=20 > > To make the performance can be tuning on different NICs or platforms. W= e > > need to make the number of descriptors and Rx/TX threshold as arguments > > when starting l3fwd application. > > > > Signed-off-by: Xiaoyun Li >=20 > Not sure about this. The point of l3fwd is to make it as simple > an application as possible to help users. >=20 > Given that drivers can now supply default values for thresholds, I think > the l3fwd sample should get rid of all the special descriptor values it > is setting. Then if the values are not right for best performance that sh= ould > be pushed back to the driver writer to fix. But now what the driver using are the arguments passed from l3fwd applicati= on, such as RTE_TEST_RX_DESC_DEFAULT. About the threshold, I guess it is alread= y done by driver to use default value. For number of descriptors, any ideas? = Diver to provide a suggestion one?