From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jingjing.wu@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 18BC01B3D1 for <dev@dpdk.org>; Fri, 13 Oct 2017 05:27:14 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2017 20:27:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,369,1503385200"; d="scan'208";a="138014593" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2017 20:27:13 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Oct 2017 20:27:13 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Oct 2017 20:27:12 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Fri, 13 Oct 2017 11:27:11 +0800 From: "Wu, Jingjing" <jingjing.wu@intel.com> To: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Chilikin, Andrey" <andrey.chilikin@intel.com>, "Xing, Beilei" <beilei.xing@intel.com> Thread-Topic: [PATCH v5 3/4] app/testpmd: add raw flow type to flow director Thread-Index: AQHTQgZ06CZWrDYbnkWrGJ6OTccMC6LhIM3w Date: Fri, 13 Oct 2017 03:27:10 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E947EA@SHSMSX103.ccr.corp.intel.com> References: <1507666412-15320-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-4-git-send-email-kirill.rybalchenko@intel.com> In-Reply-To: <1507667338-15742-4-git-send-email-kirill.rybalchenko@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/4] app/testpmd: add raw flow type to flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 13 Oct 2017 03:27:15 -0000 > break; > + case RTE_ETH_FLOW_RAW: > + raw_packet_buff =3D open_ddp_package_file(res->filepath, > + &raw_packet_size); If you think open_ddp_package_file can be used for common binary file open, could you rename it and then use it? Because it is not ddp file, right? The buffer is allocated in open_ddp_package_file, after you use it, you nee= d to free it to avoid memory leak, or call close_ddp_package_file. Even the ethdev patch is been rejected, and you may go to a private API way= . I think the comments are also worth for the raw package read. Please pay attention in later version. Thanks Jingjing