From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 82A111B66E; Fri, 3 Nov 2017 03:17:44 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2017 19:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,336,1505804400"; d="scan'208";a="917062964" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 02 Nov 2017 19:17:40 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Nov 2017 19:17:40 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Nov 2017 19:17:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Fri, 3 Nov 2017 10:17:38 +0800 From: "Wu, Jingjing" To: "Dai, Wei" , "Xing, Beilei" , "Liang, Cunming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF Thread-Index: AQHTU94KKqmtqic8iE67LPctTcyEvqMB6lqw Date: Fri, 3 Nov 2017 02:17:38 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EAC791@SHSMSX103.ccr.corp.intel.com> References: <1509628256-16300-1-git-send-email-wei.dai@intel.com> <1509628256-16300-3-git-send-email-wei.dai@intel.com> In-Reply-To: <1509628256-16300-3-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:17:45 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Thursday, November 2, 2017 9:11 PM > To: Wu, Jingjing ; Xing, Beilei ; > Liang, Cunming > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > Subject: [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF >=20 > When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to > MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in > vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound i40e = VF Rx > queue interrupts can be mapped in vector 1. And as current igb_uio only > support only one vector, i40e VF PMD should use vector 0 for igb_uio and > vector 1 for VFIO-PCI. Without this patch, VF Rx queue interrupt is mappe= d to > vector 0 in register settings and mapped to VFIO vector 1 in > vfio_enable_msix( ), and then all Rx queue interrupts will be missed. >=20 > Fixes: 4b90a3ff26c5 ("i40evf: support Rx interrupt") > Fixes: 975ffea6f671 ("net/i40e: remove DPDK PF version specific code") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 567b7d0..94fb4b1 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -654,7 +654,7 @@ i40evf_config_irq_map(struct rte_eth_dev *dev) > int i, err; >=20 > if (rte_intr_allow_others(intr_handle)) > - vector_id =3D I40EVF_VSI_DEFAULT_MSIX_INTR_LNX; > + vector_id =3D I40EVF_VSI_DEFAULT_MSIX_INTR; Firstly, We can use I40E_MISC_VEC_ID and I40E_RX_VEC_START to replace I40EV= F_VSI_DEFAULT_MSIX_INTR_LNX and I40EVF_VSI_DEFAULT_MSIX_INTR. You need to check if rx interrupt is enabled or not, if not we should use I= 40E_MISC_VEC_ID. If rx interrupt is enabled, and rte_intr_allow_others(intr_handle) is true,= then use I40E_RX_VEC_START. And I think in VFIO cases, we can use more than one interrupt for the IRQ m= apping. You can refer to the function i40e_vsi_queues_bind_intr.