From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 568761B63A; Fri, 3 Nov 2017 03:25:51 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2017 19:25:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,336,1505804400"; d="scan'208";a="171377815" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2017 19:25:50 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Nov 2017 19:25:50 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Fri, 3 Nov 2017 10:25:48 +0800 From: "Wu, Jingjing" To: "Dai, Wei" , "Xing, Beilei" , "Liang, Cunming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF Thread-Index: AQHTU94IRP0TQY7+OkGZoYbQelk2lqMB7VFQ Date: Fri, 3 Nov 2017 02:25:48 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EAC7C4@SHSMSX103.ccr.corp.intel.com> References: <1509628256-16300-1-git-send-email-wei.dai@intel.com> <1509628256-16300-2-git-send-email-wei.dai@intel.com> In-Reply-To: <1509628256-16300-2-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:25:52 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Thursday, November 2, 2017 9:11 PM > To: Wu, Jingjing ; Xing, Beilei ; > Liang, Cunming > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > Subject: [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF >=20 > When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is mapp= ed to > VFIO vector 0 in i40evf_dev_init( ). > In ixgbevf_dev_interrupt_handler( ), if previous VFIO interrupt mapping s= et in Ixgbevf? Should be i40evf? > i40evf_dev_init( ) is not cleard, it will fail when calling rte_intr_enab= le( ) tries > to map Rx queue interrupt to other VFIO vectors. This patch clears the VF= IO > interrupt mappings before setting both miscellaneous and Rx queue interru= pt > mappings again to avoid failure. >=20 > Fixes: 4b90a3ff26c5 ("i40evf: support Rx interrupt") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai > --- > drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 3b76c9e..567b7d0 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1432,8 +1432,9 @@ i40evf_dev_interrupt_handler(void *param) > " do nothing"); >=20 > done: > - i40evf_enable_irq0(hw); > + rte_intr_disable(dev->intr_handle); > rte_intr_enable(dev->intr_handle); > + i40evf_enable_irq0(hw); If that reason, you can move the rte_intr_disable to dev_start when deal wi= th the rxq setting in intr_conf. > } >=20 > static int > -- > 2.7.5