From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1D3771B600 for ; Tue, 7 Nov 2017 09:40:02 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 07 Nov 2017 00:40:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,357,1505804400"; d="scan'208";a="1215168920" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 07 Nov 2017 00:40:02 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 00:40:01 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 00:40:01 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 7 Nov 2017 16:39:59 +0800 From: "Wu, Jingjing" To: "Ananyev, Konstantin" , "Wu, Yanglong" , "dev@dpdk.org" CC: "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF Thread-Index: AQHTU7u/Gao7njflKk27vnTIHCIvwaMAmciAgAgFUUA= Date: Tue, 7 Nov 2017 08:39:59 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EB193B@SHSMSX103.ccr.corp.intel.com> References: <20171102170432.168194-1-yanglong.wu@intel.com> <20171102170432.168194-2-yanglong.wu@intel.com> <2601191342CEEE43887BDE71AB9772585FAB87A3@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAB87A3@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA4Y2MzY2EtODEwMy00YmViLTllYzYtNDNjYzdlMTEwMzNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFcL1g1cmtZaThSRTNtQjJWdEpRSzM1SVlhanFoWldybXlGMldIK1o0TERrPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 08:40:03 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, November 2, 2017 10:06 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Wu, Yanglong > Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on = PF >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > > Sent: Thursday, November 2, 2017 5:05 PM > > To: dev@dpdk.org > > Cc: Wu, Yanglong > > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF > > > > which occurred when the SRIOV is active and tx_q > rx_q. > > The number of nb_q_per_pool should equeal to max number > > of queues supported by HW not nb_rx_q. > > > > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode > > check to specific drivers) > > > > Signed-off-by: Yanglong Wu > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe= _ethdev.c > > index ae9c44421..0f0641da1 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *de= v, > uint16_t nb_rx_q) > > return -EINVAL; > > } > > > > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D nb_rx_q; > > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 128/RTE_ETH_DEV_SRIOV(dev).a= ctive; > > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * nb_rx_q; > > > > return 0; > > -- > > 2.11.0 >=20 > Not sure I understand what is the purpose of that patch... > Do you want to prevent RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 1? > Konstantin >=20 I think his purpose is to set the RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool to b= e the max number of queues in one pool according to the how to split the queue index. Now, for rss and virtualization mode, ixgbe has combination like 2 queues *= 64 pools and 4 queues * 32 pools. BTW, I think the title of this patch need to be reword. It looks confusing = if it is a bug in ixgbe. >=20 >=20 >=20