From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1328E1B395; Wed, 8 Nov 2017 06:23:55 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 07 Nov 2017 21:23:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,362,1505804400"; d="scan'208";a="918877743" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 07 Nov 2017 21:23:53 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 21:23:53 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 21:23:52 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Wed, 8 Nov 2017 13:23:51 +0800 From: "Wu, Jingjing" To: Thomas Monjalon , "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Tan, Jianfeng" , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , "Gonzalez Monroy, Sergio" , Rasesh Mody , "Lee Roberts" , Stephen Hemminger , Chas Williams Thread-Topic: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release Thread-Index: AQHTWBfiQU5ebvmeh0m8Vguvl+uicaMJEfuAgADhMhA= Date: Wed, 8 Nov 2017 05:23:50 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EB2CCA@SHSMSX103.ccr.corp.intel.com> References: <20171107193217.56357-1-ferruh.yigit@intel.com> <20171107222913.65295-1-ferruh.yigit@intel.com> <10440492.mlt1TGbLnU@xps> In-Reply-To: <10440492.mlt1TGbLnU@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 05:23:56 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, November 8, 2017 7:57 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; stable@dpdk.org; Tan, Jianfeng = ; > Wu, Jingjing ; Shijith Thotton > ; Gregory Etelson ; > Harish Patil ; George Prekas > ; Gonzalez Monroy, Sergio > ; Rasesh Mody > ; Lee Roberts ; Stephen > Hemminger ; Chas Williams > Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in releas= e >=20 > 07/11/2017 23:29, Ferruh Yigit: > > More error reported for device reset in release() [1], when device > > pass-through to the guest, host kernel crash on guest exit. > > > > Removing the reset completely. > > > > This is close to reverting commit b58eedfc7dd5 [2], taking into > > account previous fix to remove reset in open as well [3], but not exact= ly same. > > > > With latest code, interrupts are enabled in uio open() callback and > > disabled in uio release() callback, so when a DPDK application exit > > device interrupts are disabled. Previously interrupts were only > > enabled once in igb_uio module insert and disabled in module removal. > > > > Also with latest code device set as bus master in open() and master > > cleared in release(), clearing bus master should prevent further DMA > > which was one of the target of the initial patch. > > > > The initial intention was also to reset the device to be sure it has > > been left in proper state, but currently that part is missing because > > of reported problem(s). > > > > Still igb_uio should be safer comparing to the pre b58eedfc7dd5 state. > > > > [1] > > http://dpdk.org/ml/archives/dev/2017-November/081459.html > > > > [2] > > b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device > > file") > > > > [3] > > f73b38e9245d ("igb_uio: remove device reset in open") > > > > Fixes: e3a64deae2d5 ("igb_uio: prevent reset for bnx2x devices") > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of > > device file") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit >=20 > We can say you tried hard to make igb_uio cleaner and safer :) >=20 That's true! Thanks a lot, Ferruh!! > Applied, thanks for the detailed explanations.