From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5FDD21B7EA; Thu, 8 Feb 2018 13:39:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 04:39:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="25735393" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 08 Feb 2018 04:39:20 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 04:39:20 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 04:39:20 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 20:39:18 +0800 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix FDIR issue Thread-Index: AQHToNlMoFxem3qHSkeBc8qizS0Dr6Oaccyg Date: Thu, 8 Feb 2018 12:39:18 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810F711E9@SHSMSX103.ccr.corp.intel.com> References: <1518093340-22768-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1518093340-22768-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzAyZmM3NzMtNTNhOC00NjE3LTlmMjMtNWFiNDc0OTEzNDRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjF1Rkp1Q3MrNVdsRVJqbUFoNTB2cjJvdURKM0RENG5PMEJqYUdMbWpnczA9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix FDIR issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 12:39:24 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, February 8, 2018 8:36 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] app/testpmd: fix FDIR issue >=20 > This patch fixes issue during dealing with flow > director filter. >=20 > Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Beilei Xing > --- > app/test-pmd/cmdline.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index b4522f4..d1dc1de 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -9900,11 +9900,11 @@ struct cmd_flow_director_result { > uint16_t port_dst; > cmdline_fixed_string_t verify_tag; > uint32_t verify_tag_value; > - cmdline_ipaddr_t tos; > + cmdline_fixed_string_t tos; > uint8_t tos_value; > - cmdline_ipaddr_t proto; > + cmdline_fixed_string_t proto; > uint8_t proto_value; > - cmdline_ipaddr_t ttl; > + cmdline_fixed_string_t ttl; > uint8_t ttl_value; > cmdline_fixed_string_t vlan; > uint16_t vlan_value; > @@ -10515,7 +10515,7 @@ cmdline_parse_inst_t cmd_add_del_sctp_flow_direct= or =3D { > (void *)&cmd_flow_director_flow_type, > (void *)&cmd_flow_director_src, > (void *)&cmd_flow_director_ip_src, > - (void *)&cmd_flow_director_port_dst, > + (void *)&cmd_flow_director_port_src, > (void *)&cmd_flow_director_dst, > (void *)&cmd_flow_director_ip_dst, > (void *)&cmd_flow_director_port_dst, Good catch, thanks! Acked-by: Jingjing Wu