From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1C369594F for ; Thu, 13 Nov 2014 12:27:16 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 13 Nov 2014 03:30:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,376,1413270000"; d="scan'208";a="621743499" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga001.fm.intel.com with ESMTP; 13 Nov 2014 03:36:30 -0800 Received: from pgsmsx108.gar.corp.intel.com (10.221.44.103) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 13 Nov 2014 19:36:28 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 13 Nov 2014 19:36:27 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0195.001; Thu, 13 Nov 2014 19:36:26 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 05/21] i40e: implement operations to add/delete flow director Thread-Index: AQHP+T4G7X2FHIuB+02033tLbqU4V5xd1eAAgAChw6A= Date: Thu, 13 Nov 2014 11:36:25 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B49A7D@SHSMSX104.ccr.corp.intel.com> References: <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> <1414654006-7472-6-git-send-email-jingjing.wu@intel.com> <2433359.CatIjmm0iz@xps13> In-Reply-To: <2433359.CatIjmm0iz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 05/21] i40e: implement operations to add/delete flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 11:27:17 -0000 Hi, Pablo & Thomas You are correct. This is a merge mistake. Besides that, there are some comments from Konstantin, I'm reworking on thi= s patchset. The new patchset is coming soon. Thanks for reminder. Jingjing > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 13, 2014 5:50 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v5 05/21] i40e: implement operations to ad= d/delete flow > director >=20 > Hi Jingjing, >=20 > You didn't reply to Pablo's comment. > Any news of this patchset? Could it be reviewed? >=20 > Thanks > -- > Thomas >=20 > 2014-11-05 21:18, De Lara Guarch, Pablo: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu > > > Deal with two operations for flow director > > > - RTE_ETH_FILTER_ADD > > > - RTE_ETH_FILTER_DELETE > > > Encode the flow inputs to programming packet. > > > Sent the packet to filter programming queue and check status > > > on the status report queue. > > > > > > Signed-off-by: Jingjing Wu > > > --- > > > lib/librte_pmd_i40e/i40e_ethdev.c | 3 + > > > lib/librte_pmd_i40e/i40e_ethdev.h | 3 + > > > lib/librte_pmd_i40e/i40e_fdir.c | 622 > > > ++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 628 insertions(+) > > > > > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > > > b/lib/librte_pmd_i40e/i40e_ethdev.c > > > index 8195e8a..fb43efb 100644 > > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > > @@ -4577,6 +4577,7 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev, > > > enum rte_filter_op filter_op, > > > void *arg) > > > { > > > + struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > > > >dev_private); > > > int ret =3D 0; > > > > > > if (dev =3D=3D NULL) > > > @@ -4585,6 +4586,8 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev, > > > switch (filter_type) { > > > case RTE_ETH_FILTER_TUNNEL: > > > ret =3D i40e_tunnel_filter_handle(dev, filter_op, arg); > > > > Missing break here? > > > > > + case RTE_ETH_FILTER_FDIR: > > > + ret =3D i40e_fdir_ctrl_func(pf, filter_op, arg); > > > break; > > > default: > > > PMD_DRV_LOG(WARNING, "Filter type (%d) not > > > supported",