From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 814143975 for ; Tue, 25 Nov 2014 05:40:49 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 24 Nov 2014 20:48:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,453,1413270000"; d="scan'208";a="613527671" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga001.jf.intel.com with ESMTP; 24 Nov 2014 20:51:37 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 25 Nov 2014 12:51:36 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0195.001; Tue, 25 Nov 2014 12:51:36 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 00/22] Support flow director programming on Fortville Thread-Index: AQHQCD1b1sKPBa+irE2Vhzs4qxxAwJxwwulQ Date: Tue, 25 Nov 2014 04:51:34 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B550A3@SHSMSX104.ccr.corp.intel.com> References: <1414654006-7472-1-git-send-email-jingjing.wu@intel.com> <1416530816-2159-1-git-send-email-jingjing.wu@intel.com> <2601191342CEEE43887BDE71AB977258213B85BF@IRSMSX105.ger.corp.intel.com> <1836839.nqfgSfhOYr@xps13> In-Reply-To: <1836839.nqfgSfhOYr@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 00/22] Support flow director programming on Fortville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 04:40:50 -0000 Hi, Thomas Thanks a lot. >=20 > I feel the flow director features could be better explained, and probably= the > API won't be enough generic for the next driver implementing flow directo= r. > But no comment from the community means it's OK to integrate. >=20 > Now we move on this API and the old one must be removed. > Converting ixgbe to this new API must be the top priority. > It must be clear to everyone that no new Fortville feature will be accept= ed > until a full clean-up of the old filtering API. If I understand correctly, what you mean is: If the new patch is using new filter_ctrl API while the similar feature for Igb and ixgbe are using the old filtering API, we need to clean-up the old = filtering API and promote them to new filtering APIs at first. For example, if we want to enable ethertype filter on Fortville, we need to= move the igb/ixgbe's ether_type filter to new API at the same patchset. What you said is not for others features which has no relationship with fil= ter API.=20 Correct?=20 =20 >=20 > Thank you Jingjing for the big work. Step done. > Applied > -- > Thomas