From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AA4815A81 for ; Fri, 30 Jan 2015 09:22:08 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 30 Jan 2015 00:15:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="447429692" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jan 2015 00:08:13 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 30 Jan 2015 16:22:04 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.231]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0195.001; Fri, 30 Jan 2015 16:22:03 +0800 From: "Wu, Jingjing" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters Thread-Index: AQHQNhZ2jBUCh5m32ky4whL8VLB+VJzVGy+AgAGaIGA= Date: Fri, 30 Jan 2015 08:22:02 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B87B70@SHSMSX104.ccr.corp.intel.com> References: <1421286361-11504-1-git-send-email-jingjing.wu@intel.com> <1421912305-2022-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 08:22:09 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 28, 2015 10:29 PM > To: Wu, Jingjing; dev@dpdk.org > Cc: Cao, Min; Xu, HuilongX > Subject: RE: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple > filters >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Thursday, January 22, 2015 7:38 AM > > To: dev@dpdk.org > > Cc: Wu, Jingjing; De Lara Guarch, Pablo; Cao, Min; Xu, HuilongX > > Subject: [PATCH v2 0/6] new ntuple filter replaces 2tuple and 5tuple > > filters > > > > v2 changes: > > - remove the code which is already applied in patch "Integrate ethert= ype > > filter in igb/ixgbe driver to new API". > > - modify commands' description in doc testpmd_funcs.rst. > > > > The patch set uses filter_ctrl API to replace old 2tuple and 5tuple fil= ter APIs. > > It defines ntuple filter to combine 2tuple and 5tuple types. > > It uses new functions and structure to replace old ones in igb/ixgbe > > driver, new commands to replace old ones in testpmd, and removes the > old APIs. > > It removes the filter's index parameters from user interface, only the > > filter's key and assigned queue are visible to user. > > > > Jingjing Wu (6): > > ethdev: define ntuple filter type and its structure > > ixgbe: ntuple filter functions replace old ones for 5tuple filter > > e1000: ntuple filter functions replace old ones for 2tuple and 5tuple > > filter > > testpmd: new commands for ntuple filter > > ethdev: remove old APIs and structures of 5tuple and 2tuple filters > > doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter > > > > app/test-pmd/cmdline.c | 406 ++++++------- > > app/test-pmd/config.c | 65 --- > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 99 +--- > > lib/librte_ether/rte_eth_ctrl.h | 57 ++ > > lib/librte_ether/rte_ethdev.c | 116 ---- > > lib/librte_ether/rte_ethdev.h | 192 ------ > > lib/librte_pmd_e1000/e1000_ethdev.h | 69 ++- > > lib/librte_pmd_e1000/igb_ethdev.c | 869 +++++++++++++++++++-= -- > --- > > --- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 468 +++++++++++---- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 52 +- > > 10 files changed, 1300 insertions(+), 1093 deletions(-) > > > > -- > > 1.9.3 >=20 > Acked-by: Pablo de Lara >=20 > Just mind that the last patch (changing the documentation) does not apply > properly, as there was another patch (from you I think), that modifies t= hat > document. > Could you send another version of the last patch? > Not sure if that's OK or if it is better to send the full patchset again. >=20 Thank you, Pablo. Yes. It's due to another patch of doc change is applied before this one. But I think many patches will update this the document. Let's wait to see whether there are more comments about this patch set at first.=20