From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3AD642716
 for <dev@dpdk.org>; Mon, 15 Jun 2015 09:15:05 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 15 Jun 2015 00:15:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,617,1427785200"; d="scan'208";a="508375681"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by FMSMGA003.fm.intel.com with ESMTP; 15 Jun 2015 00:15:03 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 15 Jun 2015 15:15:02 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.129]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002;
 Mon, 15 Jun 2015 15:15:00 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 3/6] ethdev: extend struct to support flow
 director in VFs
Thread-Index: AQHQi50xQrm5+bAkmEO1flZjwm3cBJ2owQqAgASda1A=
Date: Mon, 15 Jun 2015 07:14:59 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F8C533B2@SHSMSX104.ccr.corp.intel.com>
References: <1431315990-3067-1-git-send-email-jingjing.wu@intel.com>
 <1431315990-3067-4-git-send-email-jingjing.wu@intel.com>
 <6248554.R1XBHJxJp6@xps13>
In-Reply-To: <6248554.R1XBHJxJp6@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "neil.horman@tuxdriver.com" <neil.horman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 3/6] ethdev: extend struct to support flow
 director in VFs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 07:15:05 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Saturday, June 13, 2015 12:45 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org; neil.horman@tuxdriver.com
> Subject: Re: [dpdk-dev] [PATCH 3/6] ethdev: extend struct to support flow
> director in VFs
>=20
> 2015-05-11 11:46, Jingjing Wu:
> > This patch extends struct rte_eth_fdir_flow_ext to support flow
> > director in VFs.
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>=20
> > --- a/lib/librte_ether/rte_eth_ctrl.h
> > +++ b/lib/librte_ether/rte_eth_ctrl.h
> > @@ -394,6 +394,8 @@ struct rte_eth_fdir_flow_ext {
> >  	uint16_t vlan_tci;
> >  	uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
> >  	/**< It is filled by the flexible payload to match. */
> > +	uint8_t is_vf;   /**< 1 for VF, 0 for port dev */
> > +	uint16_t dst_id; /**< VF ID, available when is_vf is 1*/
> >  };
>=20
> Isn't it breaking the ABI?

Yes, it is breaking the ABI. Will consider how to avoid that.

Thanks
Jingjing