From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 82458C630
 for <dev@dpdk.org>; Thu, 30 Jul 2015 02:42:09 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga102.jf.intel.com with ESMTP; 29 Jul 2015 17:42:09 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,573,1432623600"; d="scan'208";a="772730198"
Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87])
 by fmsmga002.fm.intel.com with ESMTP; 29 Jul 2015 17:42:08 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by
 KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Thu, 30 Jul 2015 08:42:04 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.38]) with mapi id 14.03.0224.002;
 Thu, 30 Jul 2015 08:41:59 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues
 on vf port
Thread-Index: AQHQyZk+tOCNG9icHEO12RcpsryFVp3yg8GAgACn2rA=
Date: Thu, 30 Jul 2015 00:41:58 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F8C9279F@SHSMSX104.ccr.corp.intel.com>
References: <1438074060-13809-1-git-send-email-jingjing.wu@intel.com>
 <1438131297-22750-1-git-send-email-jingjing.wu@intel.com>
 <1517577.ZUUS3DXQqZ@xps13>
In-Reply-To: <1517577.ZUUS3DXQqZ@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues on
 vf port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2015 00:42:10 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 30, 2015 6:33 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues
> on vf port
>=20
> > This patch fixes the issue:
> > Testpmd crashed with Segmentation fault when setup tx queues on vf
> > Steps for reproduce:
> >   - create one vf device from i40e driver
> >   - bind vf device to igb_uio and start testpmd
> >
> > With debugging tools, we saw the struct i40e_vf is cleared after
> > memcpy(&dev->data->dev_conf, dev_conf, sizeof(dev->data->dev_conf))
> in
> > rte_eth_dev_configure, which should not happen, and the pointer to
> > i40e_vf isn't in the range of i40e_adapter.
> >
> > The root cause is the dev_private_size in i40e virtual function driver
> > struct rte_i40evf_pmd was set incorrectly.
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>=20
> Applied, thanks
>=20
> Does it mean that Tx with i40evf never worked before?

Actually we didn't face crash with previous version, i40vf tx works before,=
 what makes me surprised. Maybe just lucky.=20