From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DA85AB62 for ; Thu, 14 Jan 2016 09:48:43 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 14 Jan 2016 00:48:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,293,1449561600"; d="scan'208";a="881130543" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 14 Jan 2016 00:48:20 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 14 Jan 2016 00:48:19 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0248.002; Thu, 14 Jan 2016 16:48:18 +0800 From: "Wu, Jingjing" To: 'Rahul Lakkireddy' , "Chilikin, Andrey" Thread-Topic: [dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir Thread-Index: AQHRTd9pVA90aW93N0O3H4GhTLSjCp75ZXTAgAFNbtA= Date: Thu, 14 Jan 2016 08:48:17 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8D85DED@SHSMSX104.ccr.corp.intel.com> References: <9BB6961774997848B5B42BEC655768F8D74B6B@SHSMSX104.ccr.corp.intel.com> <20160113084920.GA6469@scalar.blr.asicdesigners.com> <9BB6961774997848B5B42BEC655768F8D80272@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F8D80272@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "'dev@dpdk.org'" , 'Felix Marti' , 'Nirranjan Kirubaharan' , 'Kumar A S' Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 08:48:44 -0000 Hi, Rahul Just another thought, please consider about it: Add a new flow type like #define RTE_ETH_FLOW_IPV6_UDP_EX 17 +#define RTE_ETH_FLOW_RAW_PKT 18 Then add a new item in rte_eth_fdir_flow union rte_eth_fdir_flow { struct rte_eth_l2_flow l2_flow; struct rte_eth_udpv4_flow udp4_flow; struct rte_eth_tcpv4_flow tcp4_flow; struct rte_eth_sctpv4_flow sctp4_flow; struct rte_eth_ipv4_flow ip4_flow; struct rte_eth_udpv6_flow udp6_flow; struct rte_eth_tcpv6_flow tcp6_flow; struct rte_eth_sctpv6_flow sctp6_flow; struct rte_eth_ipv6_flow ipv6_flow; struct rte_eth_mac_vlan_flow mac_vlan_flow; struct rte_eth_tunnel_flow tunnel_flow; + uint8_t raw_pkt[80]; }; Then add mask item in rte_eth_fdir_input: struct rte_eth_fdir_input { uint16_t flow_type; union rte_eth_fdir_flow flow; + union rte_eth_fdir_flow flow_mask; /**< Flow fields to match, dependent on flow_type */ struct rte_eth_fdir_flow_ext flow_ext; /**< Additional fields to match */ }; Then the filter can be added just in a format of raw packet, it looks gener= ic, and even other NIC can use this too. Thanks Jingjing > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, January 13, 2016 9:17 PM > To: Rahul Lakkireddy > Cc: dev@dpdk.org; Felix Marti; Kumar A S; Nirranjan Kirubaharan > Subject: RE: [dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and n= ew > behavior switch to fdir >=20