From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9ABE68E5E for ; Fri, 15 Jan 2016 02:30:57 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 14 Jan 2016 17:30:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,297,1449561600"; d="scan'208";a="893535065" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2016 17:30:56 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 14 Jan 2016 17:30:56 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 14 Jan 2016 17:30:56 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.215]) with mapi id 14.03.0248.002; Fri, 15 Jan 2016 09:30:54 +0800 From: "Wu, Jingjing" To: Rahul Lakkireddy Thread-Topic: [dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir Thread-Index: AQHRTd9pVA90aW93N0O3H4GhTLSjCp75ZXTAgAFNbtD//8caAIABTsKw Date: Fri, 15 Jan 2016 01:30:53 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8D8622A@SHSMSX104.ccr.corp.intel.com> References: <9BB6961774997848B5B42BEC655768F8D74B6B@SHSMSX104.ccr.corp.intel.com> <20160113084920.GA6469@scalar.blr.asicdesigners.com> <9BB6961774997848B5B42BEC655768F8D80272@SHSMSX104.ccr.corp.intel.com> <9BB6961774997848B5B42BEC655768F8D85DED@SHSMSX104.ccr.corp.intel.com> <20160114131728.GA2434@scalar.blr.asicdesigners.com> In-Reply-To: <20160114131728.GA2434@scalar.blr.asicdesigners.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNlOTUzMzYtNjVjOS00NDRmLWEwM2MtOWY5MjRlODg2ZjNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNjdpckRiOFZoOVZhVXphTHVFakt0ckIxaHNqRGFXaGxGYnhsVGNPXC9Fb3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "'dev@dpdk.org'" , Felix Marti , Nirranjan Kirubaharan , Kumar A S Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: add packet filter flow and new behavior switch to fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 01:30:58 -0000 Hi, Rahul > This approach seems generic enough to allow any vendor specific data > to be passed in filter as well. However, 80 seems to be too low for > multiple flow types that can be combined in the same filter rule. > I think size of 256 seems reasonable. > Yes, 80 is just an example.=20 > Could the same thing be done for action arguments as well? Can we add > the same generic info to rte_eth_fdir_action too? >=20 > struct rte_eth_fdir_action { > uint16_t rx_queue; > enum rte_eth_fdir_behavior behavior; > enum rte_eth_fdir_status report_status; > uint8_t flex_off; > + uint8_t behavior_arg[256]; > }; >=20 > This way, we can pass vendor specific action arguments too. What do > you think? Yes, it also makes sense. > Also, now if we take this approach then, I am wondering, that all > vendors would need to document their own vendor-specific format of > taking filter match and filter action arguments, right? >=20 > And probably, even come up with their own example application showing > how to apply filters via dpdk on their card? Yes, I guess it will be better to doc it or example it. Even currently, dif= ferent kinds of NIC may need different configuration. Or you can add description (how to configure) in your driver's comment log? Not sure about the others' opinion? Thanks Jingjing