From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 983092B98 for ; Wed, 9 Mar 2016 11:26:31 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 09 Mar 2016 02:26:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="905885174" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 09 Mar 2016 02:26:30 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 02:26:29 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 02:26:29 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by shsmsx102.ccr.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0248.002; Wed, 9 Mar 2016 18:26:27 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for input selection Thread-Index: AQHRecaZYse2mSTSUEWJkp2HlKrVzp9QWbOAgACOYwA= Date: Wed, 9 Mar 2016 10:26:27 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8DD16C1@SHSMSX104.ccr.corp.intel.com> References: <1456918207-31696-1-git-send-email-jingjing.wu@intel.com> <1457502180-14124-1-git-send-email-jingjing.wu@intel.com> <1457502180-14124-2-git-send-email-jingjing.wu@intel.com> <1518710.DqorvmVtZj@xps13> In-Reply-To: <1518710.DqorvmVtZj@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for input selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 10:26:32 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 09, 2016 5:55 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for > input selection >=20 > 2016-03-09 13:42, Jingjing Wu: > > struct rte_eth_ipv4_flow { > > uint32_t src_ip; /**< IPv4 source address to match. */ > > uint32_t dst_ip; /**< IPv4 destination address to match. */ > > + uint8_t tos; /**< Type of service to match. */ > > + uint8_t ttl; /**< Time to live */ > > + uint8_t proto; >=20 > L4 protocol? >=20 > > }; > > > > /** > > @@ -443,6 +448,9 @@ struct rte_eth_sctpv4_flow { struct > > rte_eth_ipv6_flow { > > uint32_t src_ip[4]; /**< IPv6 source address to match. */ > > uint32_t dst_ip[4]; /**< IPv6 destination address to match. */ > > + uint8_t tc; /**< Traffic class to match. */ > > + uint8_t proto; /**< Protocol, next header. */ > > + uint8_t hop_limits; > > }; >=20 > Why some fields are not commented? > I guess the values must be the ones found in the IPv4 header. Yes, you are correct. The fields defined in rte_eth_ipvx_flow are the ones = in IP header. Should I comments all of them? Thanks Jingjing=20