From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1ABC12B9F for ; Wed, 9 Mar 2016 12:22:39 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 09 Mar 2016 03:22:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="930075483" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 09 Mar 2016 03:22:33 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 03:22:30 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 03:22:30 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Wed, 9 Mar 2016 19:22:28 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for input selection Thread-Index: AQHRecaZYse2mSTSUEWJkp2HlKrVzp9QWbOAgACOYwD//31sgIAAklUg Date: Wed, 9 Mar 2016 11:22:27 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8DD1773@SHSMSX104.ccr.corp.intel.com> References: <1456918207-31696-1-git-send-email-jingjing.wu@intel.com> <1518710.DqorvmVtZj@xps13> <9BB6961774997848B5B42BEC655768F8DD16C1@SHSMSX104.ccr.corp.intel.com> <7414420.bicRBi3CqG@xps13> In-Reply-To: <7414420.bicRBi3CqG@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for input selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 11:22:41 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 09, 2016 6:37 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 01/12] ethdev: extend flow director for > input selection >=20 > 2016-03-09 10:26, Wu, Jingjing: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-03-09 13:42, Jingjing Wu: > > > > struct rte_eth_ipv4_flow { > > > > uint32_t src_ip; /**< IPv4 source address to match. */ > > > > uint32_t dst_ip; /**< IPv4 destination address to match. */ > > > > + uint8_t tos; /**< Type of service to match. */ > > > > + uint8_t ttl; /**< Time to live */ > > > > + uint8_t proto; > > > > > > L4 protocol? > > > > > > > }; > > > > > > > > /** > > > > @@ -443,6 +448,9 @@ struct rte_eth_sctpv4_flow { struct > > > > rte_eth_ipv6_flow { > > > > uint32_t src_ip[4]; /**< IPv6 source address to match. */ > > > > uint32_t dst_ip[4]; /**< IPv6 destination address to match. = */ > > > > + uint8_t tc; /**< Traffic class to match. */ > > > > + uint8_t proto; /**< Protocol, next header. */ > > > > + uint8_t hop_limits; > > > > }; > > > > > > Why some fields are not commented? > > > I guess the values must be the ones found in the IPv4 header. > > > > Yes, you are correct. The fields defined in rte_eth_ipvx_flow are the o= nes > in IP header. > > Should I comments all of them? >=20 > Please, do I really need to confirm that the API must be clearly document= ed? OK. Just asking for your view to avoid meaningless comments. Anyway, will u= pdate. Thanks