From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 62EFC58DF for ; Wed, 23 Mar 2016 01:42:41 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 22 Mar 2016 17:42:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,379,1455004800"; d="scan'208";a="674105904" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2016 17:42:40 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Mar 2016 17:42:40 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Mar 2016 17:42:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.132]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Wed, 23 Mar 2016 08:42:38 +0800 From: "Wu, Jingjing" To: Thomas Monjalon CC: "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection Thread-Index: AQHRgzmRuVYs1+bfL0SFY0OT3dKLJp9lgXIAgACwq5A= Date: Wed, 23 Mar 2016 00:42:37 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8DDB904@SHSMSX104.ccr.corp.intel.com> References: <1457580346-18550-1-git-send-email-jingjing.wu@intel.com> <1458541132-11953-1-git-send-email-jingjing.wu@intel.com> <1458541132-11953-2-git-send-email-jingjing.wu@intel.com> <2777481.Ou9arTG791@xps13> In-Reply-To: <2777481.Ou9arTG791@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 00:42:41 -0000 Hi, Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 23, 2016 6:06 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for > input selection >=20 > 2016-03-21 14:18, Jingjing Wu: > > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering by > > tos, protocol and ttl. > [...] > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -22,10 +22,6 @@ Deprecation Notices > > * The ethdev structures rte_eth_link, rte_eth_dev_info and rte_eth_con= f > > must be updated to support 100G link and to have a cleaner link spee= d > API. > > > > -* ABI changes are planned for struct rte_eth_fdir_flow in order to > > support > > - extend flow director's input set. The release 2.2 does not contain > > these ABI > > - changes, but release 2.3 will, and no backwards compatibility is pla= nned. >=20 > The changed structures are part of rte_eth_fdir_flow. > So this deprecation notice apply to this patch. >=20 > > * ABI changes are planned for rte_eth_ipv4_flow and rte_eth_ipv6_flow > to > > include more fields to be matched against. The release 2.2 does not > > contain these ABI changes, but release 2.3 will. >=20 > These are the structures changed in this patch. > I think this section must be also removed. >=20 This deprecation notice is not raised by me. It is raised by rahul.lakkired= dy@chelsio.com at commit 954f1545a1ab. So, I'm not sure if it is OK for me to remove it in my patch. /Jingjing > > --- a/doc/guides/rel_notes/release_16_04.rst > > +++ b/doc/guides/rel_notes/release_16_04.rst > > @@ -435,6 +435,8 @@ ABI Changes > > > > * The cmdline buffer size has been increase from 256 to 512. > > > > +* The ethdev flow director structure ``rte_eth_fdir_flow`` structure > > +was > > + changed. New fields were added to extend flow director's input set. >=20 > For reading ease, it's better to group ethdev changes (before cmdline > change).