From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7D806376E for ; Fri, 27 Feb 2015 17:01:13 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 27 Feb 2015 08:01:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,660,1418112000"; d="scan'208";a="533771936" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 27 Feb 2015 07:51:55 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.69]) by IRSMSX109.ger.corp.intel.com ([169.254.13.103]) with mapi id 14.03.0195.001; Fri, 27 Feb 2015 16:01:09 +0000 From: "Gajdzica, MaciejX T" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 12/18] app/test: Remove useless code Thread-Index: AQHQUo8ku8OmGjj3PESn4jL8omlUI50Epxgg Date: Fri, 27 Feb 2015 16:01:08 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F962812E60E6A@IRSMSX102.ger.corp.intel.com> References: <1424156374-21768-1-git-send-email-helin.zhang@intel.com> <1425042696-23162-1-git-send-email-helin.zhang@intel.com> <1425042696-23162-13-git-send-email-helin.zhang@intel.com> In-Reply-To: <1425042696-23162-13-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 12/18] app/test: Remove useless code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 16:01:14 -0000 > Severl useless code lines are added accidenly, which blocks packet type > unification. They should be deleted at all. >=20 > Signed-off-by: Helin Zhang > --- > app/test/packet_burst_generator.c | 10 ---------- > 1 file changed, 10 deletions(-) >=20 > v4 changes: > * Removed several useless code lines which block packet type unification. >=20 > diff --git a/app/test/packet_burst_generator.c > b/app/test/packet_burst_generator.c > index b46eed7..b9f8f1a 100644 > --- a/app/test/packet_burst_generator.c > +++ b/app/test/packet_burst_generator.c > @@ -272,19 +272,9 @@ nomore_mbuf: > if (ipv4) { > pkt->vlan_tci =3D ETHER_TYPE_IPv4; > pkt->l3_len =3D sizeof(struct ipv4_hdr); > - > - if (vlan_enabled) > - pkt->ol_flags =3D PKT_RX_IPV4_HDR | > PKT_RX_VLAN_PKT; > - else > - pkt->ol_flags =3D PKT_RX_IPV4_HDR; > } else { > pkt->vlan_tci =3D ETHER_TYPE_IPv6; > pkt->l3_len =3D sizeof(struct ipv6_hdr); > - > - if (vlan_enabled) > - pkt->ol_flags =3D PKT_RX_IPV6_HDR | > PKT_RX_VLAN_PKT; > - else > - pkt->ol_flags =3D PKT_RX_IPV6_HDR; > } >=20 > pkts_burst[nb_pkt] =3D pkt; > -- > 1.9.3 Acked-by: Maciej Gajdzica